Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error logging when opening a bot via URL in debug mode #1949

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Oct 29, 2019

Error message and status code are now surfaced in the error notification.

Before:
notif-before

After:
notif-after

@tonyanziano tonyanziano force-pushed the toanzian/error-logging branch from b44d811 to 19ff04d Nov 1, 2019
@tonyanziano tonyanziano changed the title [DON'T MERGE] Improved error logging when opening a bot via URL in debug mode Improved error logging when opening a bot via URL in debug mode Nov 1, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 1, 2019

Coverage Status

Coverage decreased (-0.009%) to 67.087% when pulling feae31d on toanzian/error-logging into 9c4a6ce on master.

@tonyanziano tonyanziano merged commit a070872 into master Nov 5, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #88460 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/error-logging branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.