Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1904][MAS2.4.3][Focus Order - Endpoint] Focus order is not logical under "Azure bot service configuration" dropdown #1983

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@denscollo
Copy link
Collaborator

denscollo commented Nov 12, 2019

Solves #1904

Description

Fixes how focus goes to the text fields under "Azure Bot service Configuration" when the dropdown is not expanded.

Changes made

We added a tabIndex attribute to the TextFields under "Azure Bot service Configuration" section. This attribute is set to -1 on rendering and changes when the on-click event is called.

Additionally, we noticed that this issue was happening on windows as well. The same solution applies to all three platforms.

Testing

In the following images, you can see how the focus goes to the TextFields only when "Azure Bot service Configuration" section is expanded:

image
image
image

@denscollo denscollo changed the title ISSUE#1904][MAS2.4.3][Focus Order - Endpoint] Focus order is not logical under "Azure bot service configuration" dropdown [ISSUE#1904][MAS2.4.3][Focus Order - Endpoint] Focus order is not logical under "Azure bot service configuration" dropdown Nov 12, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 12, 2019

Coverage Status

Coverage increased (+0.002%) to 67.094% when pulling 8636f77 on fix/incorrect-focus-order-endpointEditor into e7f4c3b on master.

Copy link
Contributor

tonyanziano left a comment

Looks good!

@tonyanziano tonyanziano merged commit 8d8079d into master Nov 13, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #89621 succeeded
Details
license/cla All CLA requirements met.
@tonyanziano tonyanziano deleted the fix/incorrect-focus-order-endpointEditor branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.