Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote emulator/core package & moved to app/main. #1989

Merged
merged 2 commits into from Nov 18, 2019
Merged

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Nov 16, 2019

#1969

===

Highlights:

  • Removed emulator/core & emulator/cli
    • emulator/core has been moved under app/main/server
    • emulator/cli has been removed since it was not being used anywhere, the current structure of app/main/server is organized in a way that it should be invokable via a CLI if we want to bring that functionality back
  • New folder structure for REST server backend of the Emulator should be easier to understand at a glance:
main/
  src/
    server/            // where what was previously emulator/core lives
      routes/          // this is where all the endpoints and their handlers live
        channel/       // what the bot interacts with
        directLine/    // what the client interacts with (user through Web Chat)
        emulator/      // used for firing actions within the app (can call from client to check for updates or write to disk, etc.)
      state/           // classes for REST server in-memory state (conversations, endpoints, users) -- what used to be known as facilities
  • Pruned a lot of unnecessary code having to do with handling routes
  • Consolidated components under the Emulator.ts class so that instead of accessing conversation state via emulator.framework.server.botEmulator.facilities.conversations, it can now be accessed via emulator.server.state.conversations
  • Deprecated all /v3/botstate/ endpoints (See blog post for more info)
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 16, 2019

Coverage Status

Coverage increased (+0.9%) to 68.461% when pulling 9094f7e on toanzian/core-rebased into 1f0e1e6 on master.

@tonyanziano tonyanziano force-pushed the toanzian/core-rebased branch from d034f36 to 595a5b7 Nov 18, 2019
@tonyanziano tonyanziano force-pushed the toanzian/core-rebased branch from 595a5b7 to f406196 Nov 18, 2019
@cwhitten cwhitten merged commit e3ea45b into master Nov 18, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #90720 succeeded
Details
license/cla All CLA requirements met.
Details
@cwhitten cwhitten deleted the toanzian/core-rebased branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.