Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1907] Add / sort service menus now show under trigger buttons. #1993

Merged
merged 5 commits into from Nov 20, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Nov 19, 2019

#1907

===

The add and sort service pane buttons spawn a context menu. The old behavior spawned the menu at the cursors' current position (Electron's default). Now, the context menu is spawned directly under the triggering button.

Before:

image

sort-service-before

After:
add-service-after
sort-service-after

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 19, 2019

Coverage Status

Coverage increased (+0.07%) to 68.529% when pulling 9992506 on toanzian/acc-#1907 into 99c46c8 on master.

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1907 branch from 09a21b2 to 44e10dd Nov 19, 2019
@tonyanziano tonyanziano force-pushed the toanzian/acc-#1907 branch from 44e10dd to 4d47c62 Nov 19, 2019
tonyanziano added 2 commits Nov 19, 2019
@tonyanziano tonyanziano merged commit dbc1b91 into master Nov 20, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #91187 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1907 branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.