Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1904][MAS2.4.3] [Focus Order - Endpoint] Focus order is not logical under "Azure bot service configuration" dropdown. #1994

Merged
merged 3 commits into from Nov 19, 2019

Conversation

@denscollo
Copy link
Collaborator

denscollo commented Nov 19, 2019

Solves #1904

Description

Fixes the VO navigation when the Azure Bot Service Configuration is collapsed.

Changes made

We added an aria-hidden attribute to the abs-config-content component that will be true or false if the content is collapsed or expanded.

Testing

abs-config

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 19, 2019

Coverage Status

Coverage increased (+0.04%) to 68.503% when pulling b1a7fdc on fix/vo-azure-bot-service-configuration-focus into b84c941 on master.

Copy link
Contributor

tonyanziano left a comment

Add a changelog entry and I'll merge it in :)

@denscollo

This comment has been minimized.

Copy link
Collaborator Author

denscollo commented Nov 19, 2019

Thanks @tonyanziano ! We just updated the changelog 😄

Copy link
Contributor

tonyanziano left a comment

Nice job!

@tonyanziano tonyanziano merged commit b7d969d into master Nov 19, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #90944 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the fix/vo-azure-bot-service-configuration-focus branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.