Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased ngrok spawn timeout to 15 seconds. #1998

Merged
merged 1 commit into from Nov 20, 2019
Merged

Increased ngrok spawn timeout to 15 seconds. #1998

merged 1 commit into from Nov 20, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Nov 20, 2019

Carrying over the fix for an issue that users were experiencing when trying to connect to remote bots on slower networks.

===

Users on faster networks should not notice any change, and users on slower networks should no longer be broken / intermittently broken.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 20, 2019

Coverage Status

Coverage remained the same at 68.529% when pulling 549dd0d on toanzian/ngrok into 660373c on master.

@tonyanziano tonyanziano merged commit c2bee8b into master Nov 20, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #91290 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/ngrok branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.