Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1906] Fixed bugs within connected service editor. #2000

Merged
merged 1 commit into from Nov 21, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Nov 21, 2019

#1906

===

There was a bug in the ConnectedServiceEditor code that was causing botframework-config to throw, which then broke the saga that originally opened the add service context menu. This subsequently broke all future interactions with the service sagas, preventing the context menu or service buttons from working anymore.

I added code to initialize the QnA Maker service editor with a sample host name to satisfy botframework-config and prevent the error from being thrown.

There was also another bug where the learnMoreLinkButton function was being called like a getter even though it was a function, and so none of the service editors were actually rendering the learn more links, which is now fixed.

broken-links

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 21, 2019

Coverage Status

Coverage increased (+0.1%) to 68.673% when pulling a493304 on toanzian/acc-#1906 into c2bee8b on master.

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1906 branch from 64dfdaf to a493304 Nov 21, 2019
@tonyanziano tonyanziano merged commit bae6e82 into master Nov 21, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #91629 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1906 branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.