Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[ISSUE#1908][MAS4.2.10][Focus Order - Add other service] With voiceover consolidated focus goes on "Key and Value". #2002
This pull request fixes the navigation with Voiceover through the key-value pair text fields in the Add other service ... dialog.
Now voiceover goes from the label
We moved the labels used for the titles inside the first TextField element of the pairs, this way the label is associated with the input field it corresponds.
Also, we changed how the key-value pairs are displayed in the dialog, replacing a list for a table using rows as the tester suggested.
Finally, we made some changes to the styling to have the same visual representation as before. For this, we moved some style properties inside a new class to be used for the rows.
tonyanziano left a comment
This behavior doesn't seem correct to me. After adding another row of key value pairs, the behavior is that it navigates from the key label, to the input for key0, to the value label, to the input for value0, and then to key1, and to value1.
This seems to me like it would confuse a user relying on the screen reader. I think this one particular component might actually be worth wrapping in a table structure with
Because with this current implementation we still have the same pattern that existed before when accessing rows 1+.
Also, tests for