Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1913] Fixed a11y issue with json viewer component. #2009

Merged
merged 1 commit into from Nov 25, 2019
Merged

[#1913] Fixed a11y issue with json viewer component. #2009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1997](https://github.com/microsoft/BotFramework-Emulator/pull/1997)
- [1999](https://github.com/microsoft/BotFramework-Emulator/pull/1999)
- [2000](https://github.com/microsoft/BotFramework-Emulator/pull/2000)
- [2009](https://github.com/microsoft/BotFramework-Emulator/pull/2009)

- [main] Increased ngrok spawn timeout to 15 seconds to be more forgiving to slower networks in PR [1998](https://github.com/microsoft/BotFramework-Emulator/pull/1998)

Expand Down
1 change: 0 additions & 1 deletion packages/sdk/ui-react/src/widget/collapsibleJsonViewer/collapsibleJsonViewer.tsx
View file
Open in desktop
Expand Up @@ -135,7 +135,6 @@ export class CollapsibleJsonViewer extends Component<CollapsibleJsonViewerProps,
ref.firstElementChild.setAttribute('role', 'tree');
// <ul><li>
this.nodesAdded(ref.firstElementChild.childNodes);
(ref.firstElementChild as HTMLElement).tabIndex = 0;
}
this.jsonViewerElement = ref;
};
Expand Down