Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1956] Fixed welcome page tab navigation a11y issue. #2015

Merged
merged 2 commits into from Dec 9, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Dec 8, 2019

#1956

===

Applied same logic used in fix #2001 to Linux OS.

The other issue with hidden links inside some service dialogs has also been fixed (but not by this PR):

image

(Also moved code from packages/app/main/utils/platform.ts to packages/app/shared because it was being imported into client from main.)

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 8, 2019

Coverage Status

Coverage increased (+0.007%) to 68.758% when pulling a5b3fab on toanzian/acc-#1956 into b20fa50 on master.

Copy link
Member

corinagum left a comment

LGTM!

@tonyanziano tonyanziano merged commit 9ee0b73 into master Dec 9, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #94618 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1956 branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.