Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1979] Enabled HTML-based app menu for Linux. #2020

Merged
merged 2 commits into from Dec 9, 2019
Merged

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Dec 8, 2019

#1979

===

DO NOT MERGE UNTIL #2015 IS MERGED Good to merge now 馃憤

Switched from native application menu to HTML-based application menu on Linux for keyboard accessibility.

Due to a bug in Electron, disabling the native menu doesn't work like it does in Windows, and so there is an empty space at the top of application window where the menu would usually be. This is a small side effect.

electron/electron#16521

image

image

image

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 8, 2019

Coverage Status

Coverage increased (+0.001%) to 68.759% when pulling bfc461a on toanzian/acc-#1979 into a106274 on master.

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1979 branch from 6e21894 to 710d634 Dec 9, 2019
Copy link
Member

corinagum left a comment

LGTM~

@tonyanziano tonyanziano merged commit 7e922ad into master Dec 9, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #94672 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1979 branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.