Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1979] Fixed app menu tab navigation issue on Linux. #2022

Merged
merged 1 commit into from Dec 10, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Dec 10, 2019

#1979

===

  • Actually fixing it this time 馃槄
  • When the tab focus logic was running it was only looking inside the nav bar for the first focusable element, when it actually needs to look in the app menu on Linux

Video of it working:

linux-tab-nav.zip

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 10, 2019

Coverage Status

Coverage increased (+0.009%) to 68.768% when pulling d1806fa on toanzian/acc-#1979 into 7e922ad on master.


if (tabPressed) {
const lastDecendants = EventHandlers.getLastDecendants(document.querySelector('main'));

This comment has been minimized.

Copy link
@cwhitten

cwhitten Dec 10, 2019

Member

the only other way I've done this is with document.querySelectorAll and slicing the resulting array up.

@tonyanziano tonyanziano merged commit c536dec into master Dec 10, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #95055 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1979 branch Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.