Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new telemetry events and properties. #2063

Merged
merged 3 commits into from Jan 31, 2020
Merged

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Jan 27, 2020

Fixes #2035

===

  • Added toolName: 'bf-emulator' to all outgoing events so that we can filter them out from other tools (bf-cli) that use the same Azure Application Insights instance
  • removed livechat_openRemote event and added livechat_open which tracks both local and remote URLs being opened
  • added tracking for whether a livechat opened is for gov cloud or not
  • added tracking for whether a livechat opened is in debug mode or not
  • consolidated Azure signin events (signIn_success and signIn_failure) into one event (azure_signIn) that now tracks success and persistLogin
  • added an event (ngrok_reconnect) for when the user reconnects to ngrok
  • added an event (app_changeSetting) that tracks whenever a single or multiple app settings are changed at one time
  • added an event (oauth_sendToken) that tracks when an OAuth flow is completed and a token is sent to the bot
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 27, 2020

Coverage Status

Coverage increased (+0.08%) to 68.062% when pulling f43eb80 on toanzian/telemetry into 8201114 on master.

@@ -125,7 +125,7 @@ describe('TelemetryService', () => {
});

it('should track events', () => {
Object.assign(global, { __JEST_ENV__: false });
global['__JEST_ENV__'] = false;

This comment has been minimized.

Copy link
@tonyanziano

tonyanziano Jan 29, 2020

Author Contributor

I couldn't get spread to work for whatever reason

@tonyanziano tonyanziano force-pushed the toanzian/telemetry branch from ee52ca1 to a91edcc Jan 30, 2020
@tonyanziano tonyanziano merged commit d3d9bf5 into master Jan 31, 2020
2 checks passed
2 checks passed
Emulator-CI-PR #103063 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/telemetry branch Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.