Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with adding a QnA KB. #2066

Merged
merged 2 commits into from Jan 29, 2020
Merged

Fixed an issue with adding a QnA KB. #2066

merged 2 commits into from Jan 29, 2020

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Jan 28, 2020

Fixes #1875

===

  • After signing into Azure, trying to add a QnA maker KB would cause the in-memory QnA maker service to be initialized with a blank hostname, which was causing msbot to throw and crash the app
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 29, 2020

Coverage Status

Coverage increased (+0.002%) to 69.576% when pulling c20dc22 on toanzian/qnamaker into e200c7f on master.

@tonyanziano tonyanziano merged commit 1c5e370 into master Jan 29, 2020
2 checks passed
2 checks passed
Emulator-CI-PR #102358 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/qnamaker branch Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.