Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saga wrapper and webchat bump #2094

Merged
merged 3 commits into from Mar 7, 2020
Merged

Saga wrapper and webchat bump #2094

merged 3 commits into from Mar 7, 2020

Conversation

@srinaath
Copy link
Contributor

srinaath commented Mar 7, 2020

This PR handles

  1. Webchat bumped to 4.8
  2. Error handling for all sagas and helps make them stay alive after errors until we move to 1.0+ where the onError hook will be utilized
  3. Multiple clicks on Restart Conversation was not working before. It has been fixed now
Srinaath Ravichandran added 2 commits Mar 7, 2020
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Handling saga errors

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Revert res.ok

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Track saga error

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Srinaath Ravichandran
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Srinaath Ravichandran
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 7, 2020

Coverage Status

Coverage decreased (-0.008%) to 67.749% when pulling fe55270 on srravich/feature/bump-webchat into b844f3d on master.

Copy link
Contributor

tonyanziano left a comment

Looks good!

function* rootSaga() {
yield all(
applicationSagas.map(saga =>
spawn(function*() {
while (true) {
try {
yield call(saga);
break;
} catch (error) {
console.error('Saga error: ', error); // eslint-disable-line
}
}
})
)
);
}
sagaMiddleware.run(rootSaga);
Comment on lines +145 to +161

This comment has been minimized.

Copy link
@tonyanziano

tonyanziano Mar 7, 2020

Contributor

Nice!

@cwhitten cwhitten merged commit 155eaac into master Mar 7, 2020
2 checks passed
2 checks passed
Emulator-CI-PR #111543 succeeded
Details
license/cla All CLA requirements met.
Details
@cwhitten cwhitten deleted the srravich/feature/bump-webchat branch Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.