Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing item in File menu on Win / Lin. #2100

Merged
merged 2 commits into from Mar 12, 2020
Merged

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Mar 12, 2020

There was a small bug in the File menu on Windows & Linux due to the addition of the Ngrok Debugger menu item. The PR #2032 that added that menu item added 2 new menu items, (the menu item itself and the separator), but the sign in and close tab menu items never had their indices adjusted to compensate for it.

So the "Close tab" menu item was being overwritten by the sign in item.

Before fix:

fix-before

After fix:

fix-after

@tonyanziano tonyanziano merged commit 08315f6 into v4.8.0 Mar 12, 2020
1 check passed
1 check passed
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/file-menu branch Mar 12, 2020
srinaath added a commit that referenced this pull request Mar 13, 2020
* Fixed missing item in File menu on Win / Lin. (#2100)

* Fixed missing item in File menu on Win / Lin.

* Fixed changelog entry PR #

* Bump version to 4.8.0 (#2101)

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>

Co-authored-by: Tony Anziano <toanzian@microsoft.com>
Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath pushed a commit that referenced this pull request Mar 18, 2020
* Fixed missing item in File menu on Win / Lin. (#2100)

* Fixed missing item in File menu on Win / Lin.

* Fixed changelog entry PR #

* Bump version to 4.8.0 (#2101)

* Package updated

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* Added missing icon file for Linux / Mac (#2104)

* Prevent passing props to activity middleware (#2105)

* Prevent passing props to activity middleware

* Package lock updated

* Changelog updated

* Corrected changelog

* Added tests to ensure restart bubble not present (#2107)

Should hide restart bubble if speech bot

Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>

* Fixed a bug that was causing a blank User 'id' field. (#2108)

* Fixed a bug that was causing a blank User 'id' field.

* Added extra assertion in tests.

* Ngrok Startup Options (#2111)

* Make sure ngrok running loop not hit everytime

* Ngrok reporting made accurate (#2113)

* Recator isUsingNgrok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.