Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing icon file for Linux / Mac #2104

Merged
merged 1 commit into from Mar 13, 2020
Merged

Added missing icon file for Linux / Mac #2104

merged 1 commit into from Mar 13, 2020

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Mar 13, 2020

In PR #2077 the file root/packages/app/main/scripts/config/resources/icon.icns was removed accidentally because it was not referenced anywhere in the build configuration. However, it is actually used as the default value location for the app icon for the DMG and AppImage binaries output by electron-builder.

This PR restores that file so that the correct application icon once again shows correctly on Mac & Linux. Windows is unaffected.

Before:

image

After:

linux-icon-fix

@tonyanziano tonyanziano merged commit 186d8e2 into v4.8.1 Mar 13, 2020
1 check passed
1 check passed
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/icon-fix branch Mar 13, 2020
srinaath pushed a commit that referenced this pull request Mar 18, 2020
* Fixed missing item in File menu on Win / Lin. (#2100)

* Fixed missing item in File menu on Win / Lin.

* Fixed changelog entry PR #

* Bump version to 4.8.0 (#2101)

* Package updated

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* Added missing icon file for Linux / Mac (#2104)

* Prevent passing props to activity middleware (#2105)

* Prevent passing props to activity middleware

* Package lock updated

* Changelog updated

* Corrected changelog

* Added tests to ensure restart bubble not present (#2107)

Should hide restart bubble if speech bot

Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>

* Fixed a bug that was causing a blank User 'id' field. (#2108)

* Fixed a bug that was causing a blank User 'id' field.

* Added extra assertion in tests.

* Ngrok Startup Options (#2111)

* Make sure ngrok running loop not hit everytime

* Ngrok reporting made accurate (#2113)

* Recator isUsingNgrok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.