diff --git a/CHANGELOG.md b/CHANGELOG.md index 63ab9914f4..17e15845b5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -59,6 +59,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fix [#1627](https://github.com/Microsoft/BotFramework-WebChat/issues/1627). Fixed timestamps randomly stopped from updating, by [@compulim](https://github.com/compulim) in PR [#2090](https://github.com/Microsoft/BotFramework-WebChat/pull/2090) - Fix [#2001](https://github.com/Microsoft/BotFramework-WebChat/issues/2001). Strip Markdown from ARIA labels, so screen readers do not speak Markdown in text, by [@corinagum](https://github.com/corinagum) in PR [#2096](https://github.com/Microsoft/BotFramework-WebChat/pull/2096) - Fix [#1926](https://github.com/microsoft/BotFramework-WebChat/issues/1926). Fixed scroll stickiness issue when submitting an Adaptive Card form with suggested actions opened, by [@compulim](https://github.com/compulim) in PR [#2107](https://github.com/microsoft/BotFramework-WebChat/pull/2107) +- Fix [#2106](https://github.com/Microsoft/BotFramework-WebChat/issues/2016). Fix AdaptiveCardHostConfig warning associated with the CommonCard component, by [@tdurnford](https://github.com/tdurnford) in PR [#2108](https://github.com/Microsoft/BotFramework-WebChat/pull/2108) ### Samples diff --git a/packages/bundle/src/adaptiveCards/Attachment/AnimationCardAttachment.js b/packages/bundle/src/adaptiveCards/Attachment/AnimationCardAttachment.js index 43224d5b97..e7788bc9c8 100644 --- a/packages/bundle/src/adaptiveCards/Attachment/AnimationCardAttachment.js +++ b/packages/bundle/src/adaptiveCards/Attachment/AnimationCardAttachment.js @@ -26,7 +26,13 @@ class AnimationCardAttachment extends React.Component { } render() { - const { adaptiveCards, attachment, attachment: { content: { media = [] } = {} } = {}, styleSet } = this.props; + const { + adaptiveCardHostConfig, + adaptiveCards, + attachment, + attachment: { content: { media = [] } = {} } = {}, + styleSet + } = this.props; return (
@@ -41,13 +47,18 @@ class AnimationCardAttachment extends React.Component { ))} - +
); } } AnimationCardAttachment.propTypes = { + adaptiveCardHostConfig: PropTypes.any.isRequired, adaptiveCards: PropTypes.any.isRequired, attachment: PropTypes.shape({ content: PropTypes.shape({ diff --git a/packages/bundle/src/adaptiveCards/Attachment/AudioCardAttachment.js b/packages/bundle/src/adaptiveCards/Attachment/AudioCardAttachment.js index b29edce60c..c610ae289d 100644 --- a/packages/bundle/src/adaptiveCards/Attachment/AudioCardAttachment.js +++ b/packages/bundle/src/adaptiveCards/Attachment/AudioCardAttachment.js @@ -9,9 +9,12 @@ import CommonCard from './CommonCard'; const { AudioContent } = Components; const AudioCardAttachment = ({ + adaptiveCardHostConfig, adaptiveCards, attachment, - attachment: { content: { autostart = false, autoloop = false, image: { url: imageURL = '' }, media = [] } = {} } = {}, + attachment: { + content: { autostart = false, autoloop = false, image: { url: imageURL = '' } = {}, media = [] } = {} + } = {}, styleSet }) => (
@@ -22,11 +25,12 @@ const AudioCardAttachment = ({ ))} - +
); AudioCardAttachment.propTypes = { + adaptiveCardHostConfig: PropTypes.any.isRequired, adaptiveCards: PropTypes.any.isRequired, attachment: PropTypes.shape({ content: PropTypes.shape({ diff --git a/packages/bundle/src/adaptiveCards/Attachment/SignInCardAttachment.js b/packages/bundle/src/adaptiveCards/Attachment/SignInCardAttachment.js index e6669cbd86..c3e1c2905b 100644 --- a/packages/bundle/src/adaptiveCards/Attachment/SignInCardAttachment.js +++ b/packages/bundle/src/adaptiveCards/Attachment/SignInCardAttachment.js @@ -4,13 +4,14 @@ import React from 'react'; import CommonCard from './CommonCard'; -const SignInCardAttachment = ({ adaptiveCards, attachment, styleSet }) => ( +const SignInCardAttachment = ({ adaptiveCardHostConfig, adaptiveCards, attachment, styleSet }) => (
- +
); SignInCardAttachment.propTypes = { + adaptiveCardHostConfig: PropTypes.any.isRequired, adaptiveCards: PropTypes.any.isRequired, attachment: PropTypes.any.isRequired, styleSet: PropTypes.shape({ diff --git a/packages/bundle/src/adaptiveCards/Attachment/VideoCardAttachment.js b/packages/bundle/src/adaptiveCards/Attachment/VideoCardAttachment.js index 820aa89f72..6a7a83a51d 100644 --- a/packages/bundle/src/adaptiveCards/Attachment/VideoCardAttachment.js +++ b/packages/bundle/src/adaptiveCards/Attachment/VideoCardAttachment.js @@ -9,6 +9,7 @@ import CommonCard from './CommonCard'; const { VideoContent } = Components; const VideoCardAttachment = ({ + adaptiveCardHostConfig, adaptiveCards, attachment, attachment: { content: { media, autostart, autoloop, image: { url: imageURL } = {} } = {} } = {}, @@ -22,11 +23,12 @@ const VideoCardAttachment = ({ ))} - + ); VideoCardAttachment.propTypes = { + adaptiveCardHostConfig: PropTypes.any.isRequired, adaptiveCards: PropTypes.any.isRequired, attachment: PropTypes.shape({ content: PropTypes.shape({