Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usable]Name for 'Download icon' button is not properly defined. #1316

Closed
priysn opened this issue Nov 5, 2018 · 2 comments
Closed

[Usable]Name for 'Download icon' button is not properly defined. #1316

priysn opened this issue Nov 5, 2018 · 2 comments
Assignees
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing
Milestone

Comments

@priysn
Copy link

priysn commented Nov 5, 2018

Actual Result:
When focus lands on 'download icon' in scan mode then narrator is reading "Empty paragraph".
Name property is not properly defined for 'Download icons'.

Note - Same issue repro at -

  1. URL -> Help -> Document Data URI button/File attachments Button -> Download button icon - When focus lands on 'download icon' forward navigation of scan mode then narrator is reading "Empty paragraph", narrator not reading the name for download icon.

Expected Result:
When focus lands on 'download icon' in scan mode then narrator should not read "Empty paragraph".
Name property should be properly defined for 'download icons'

Repro Steps:

  1. Open URL https://microsoft.github.io/BotFramework-WebChat/full-bundle/ in Edge browser.
  2. Notice 'Upload File' and 'Send' button icons present in bottom of screen.
  3. Type 'accessibility' in the input control at the bottom of the screen and hit enter (or click on send button).
  4. Page will upload.
  5. Open Narrator with scan mode (Caps+Space).
  6. Navigate to "download icon" by using Up/Down Arrow keys.
  7. Observe that Narrator is not reading name for "download icon" while navigate in the scan mode.

User Impact:
If Name property is not defined properly for control then the users will get confuse about the purpose of that control.

Test Environment:
OS: Windows 10
OS Build: 17134.345
OS Version: 1803
Browser: Edge
Tool: Narrator

Attachment:
Usable_Name for download icon.zip

@priysn priysn added bug Indicates an unexpected problem or an unintended behavior. area-accessibility HCL_BotFramework_WebChat labels Nov 5, 2018
@priysn priysn changed the title Screen reader not reading name for "download icon" while navigate in the scan mode. [MAS4.1.2]Screen reader not reading name for "download icon" while navigate in the scan mode. Nov 15, 2018
@priysn priysn changed the title [MAS4.1.2]Screen reader not reading name for "download icon" while navigate in the scan mode. [MAS4.1.2] Name property does not define for "download icon" while navigate in the scan mode. Nov 15, 2018
@priysn priysn changed the title [MAS4.1.2] Name property does not define for "download icon" while navigate in the scan mode. [Usable] Name property does not define for "download icon" while navigate in the scan mode. Nov 15, 2018
@priysn priysn changed the title [Usable] Name property does not define for "download icon" while navigate in the scan mode. [Usable]Screen reader not reading name for "download icon" while navigate in the scan mode. Nov 15, 2018
@priysn priysn changed the title [Usable]Screen reader not reading name for "download icon" while navigate in the scan mode. [Usable]Name for 'Download icon' button is not properly defined. Nov 26, 2018
@corinagum
Copy link
Contributor

DownloadIcon .js needs localized text -- aria-label "Download file"

@corinagum corinagum added front-burner 4.3 p1 Painful if we don't fix, won't block releasing and removed UnderReview labels Nov 28, 2018
@compulim compulim added this to the v4.3 milestone Nov 28, 2018
@corinagum corinagum self-assigned this Dec 7, 2018
@Amit8527510735
Copy link

Amit8527510735 commented Nov 17, 2020

#HCL;#Accessibility;#HCL_BotFramework_WebChat;#A11yUsable;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests

4 participants