New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move `styleSet` related to Adaptive Cards and rich cards to full bundle #1969

Closed

compulim opened this issue May 7, 2019 · 0 comments · Fixed by #1987

Assignees

Labels

bug front-burner p1

Contributor

compulim commented May 7, 2019

Since we moved Adaptive Cards to full bundle, we should also move related styleSet.

Note:

When user loading full bundle, they call window.WebChat.createStyleSet, this should produce a style set that include Adaptive Cards stuff
When user loading minimal bundle, they call window.WebChat.createStyleSet, this should not produce a style set with Adaptive Cards specific stuff
Please write a simple unit test to make sure we capture the notes above. No need visual regression test

The text was updated successfully, but these errors were encountered:

compulim assigned corinagum

corinagum added 4.5 bug front-burner labels

cwhitten added the p1 label

corinagum mentioned this issue

Fix create style set with ac #1987

Merged

1 task

corinagum closed this as completed in #1987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment