Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples update #1435

Merged
merged 7 commits into from
Dec 4, 2018
Merged

Conversation

corinagum
Copy link
Contributor

Resolves #1332

@coveralls
Copy link

coveralls commented Dec 4, 2018

Pull Request Test Coverage Report for Build 536

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 82 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-6.3%) to 38.703%

Files with Coverage Reduction New Missed Lines %
packages/core/src/actions/incomingActivity.js 1 50.0%
packages/component/src/Attachment/ImageAttachment.js 1 0.0%
packages/component/src/Middleware/Activity/createCoreMiddleware.js 1 62.5%
packages/component/src/Utils/textFormatToContentType.js 1 42.86%
packages/component/src/Localization/Localize.js 1 34.94%
packages/component/src/Attachment/ImageContent.js 2 0.0%
packages/bundle/src/renderMarkdown.js 2 12.5%
packages/component/src/Activity/Timestamp.js 2 0.0%
packages/component/src/Activity/CarouselLayout.js 4 14.29%
packages/component/src/Utils/CroppedImage.js 5 12.5%
Totals Coverage Status
Change from base Build 522: -6.3%
Covered Lines: 631
Relevant Lines: 1412

💛 - Coveralls

@compulim
Copy link
Contributor

compulim commented Dec 4, 2018

Perfect!

@corinagum corinagum merged commit ed55d06 into microsoft:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants