Updated Markdown-it render options #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
compulim
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1429
Changelog Entry
Fix #1429. Changed Markdown-it options to render newline characters correctly, by @tdurnford in PR #1988
Description
When Markdown-it's
breaksoption is set to true, the renderer interprets all newline characters (\n) as line break elements (<br />), which is not the desired behavior for Web Chat. Setting the option to false changes the renderer's interpretation of a newline character to a new line within the paragraph tag unless it is preceded by two space characters. In that case, the renderer converts the newline character to a line break.Specific Changes
Changed the Markdown-it
breaksoption from true to false in renderMarkDownTesting Added