From e0b2f93b7e789368e2ad525ab55f1950be3e0f21 Mon Sep 17 00:00:00 2001 From: William Wong Date: Tue, 21 May 2019 11:27:43 -0700 Subject: [PATCH 1/2] Should not stop after first spoken text --- packages/core/src/sagas/startDictateAfterSpeakActivitySaga.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/src/sagas/startDictateAfterSpeakActivitySaga.js b/packages/core/src/sagas/startDictateAfterSpeakActivitySaga.js index d3c5d877d7..acc7877a0e 100644 --- a/packages/core/src/sagas/startDictateAfterSpeakActivitySaga.js +++ b/packages/core/src/sagas/startDictateAfterSpeakActivitySaga.js @@ -5,14 +5,14 @@ import { } from 'redux-saga/effects'; import { MARK_ACTIVITY } from '../actions/markActivity'; -import { ofID as activitiesOfID } from '../selectors/activities'; +import selectActivities from '../selectors/activities'; import speakingActivity from '../definitions/speakingActivity'; import startDictate from '../actions/startDictate'; import whileConnected from './effects/whileConnected'; import whileSpeakIncomingActivity from './effects/whileSpeakIncomingActivity'; function* startDictateAfterAllActivitiesSpoken({ payload: { activityID } }) { - const activities = yield select(activitiesOfID(activityID)); + const activities = yield select(selectActivities); const [spokenActivity] = activities; if ( From 4854f84f602ac7cf8216b4ffeafec900cfe5b097 Mon Sep 17 00:00:00 2001 From: William Wong Date: Tue, 21 May 2019 11:33:15 -0700 Subject: [PATCH 2/2] Add entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3d6fe1b76c..95ca7e6d6d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,6 +37,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fix [#1980](https://github.com/Microsoft/BotFramework-WebChat/issues/1980). Changed sendBoxTextArea styles to break words longer than the textarea, by [@tdurnford](https://github.com/tdurnford) in PR [#1986](https://github.com/Microsoft/BotFramework-WebChat/pull/1986) - Fix [#1969](https://github.com/Microsoft/BotFramework-WebChat/issues/1969). Move `styleSet`s related to Adaptive Cards to full bundle, by [@corinagum](https://github.com/corinagum) in PR [#1987](https://github.com/Microsoft/BotFramework-WebChat/pull/1987) - Fix [#1429](https://github.com/Microsoft/BotFramework-WebChat/issues/1429). Changed Markdown-it options to render newline characters correctly, by [@tdurnford](https://github.com/tdurnford) in PR [#1988](https://github.com/Microsoft/BotFramework-WebChat/pull/1988) +- Fix [#1736](https://github.com/Microsoft/BotFramework-WebChat/issues/1736). Fixed only first activity in a batch is spoken, by [@compulim](https://github.com/compulim) in PR [#2016](https://github.com/Microsoft/BotFramework-WebChat/pull/2016) ## [4.4.1] - 2019-05-02