Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate recovery share submission #5832

Merged

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Nov 13, 2023

Closes #5821, and makes new API compliant with the spec.

@lynshi as discussed.

TODO:

  • Fix LTS compatibility test by remapping arguments and calling the script with the right arguments depending on what it supports.

@achamayou achamayou requested a review from a team as a code owner November 13, 2023 16:10
@ccf-bot
Copy link
Collaborator

ccf-bot commented Nov 13, 2023

authenticate_recovery_share_submission@78728 aka 20231114.7 vs main ewma over 20 builds from 78365 to 78718

Click to see table

main

build_id build_number pi_basic_mt_virtual_cft^ Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ hist_sgx_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states tlc_sim_traces tlc_sim_levelmean
78365 20231103.6 72764.7 0.787105 17440.6 45729.3 48139.6 54762.3 4342.9 17317.7 19576 15085.7 14683.7 9954.18 43491.4 5629.97 8.59996e+07 14078.6 1.88908e+07 14064.8 1.05021e+07 15659.9 1.25993e+07 1424 1.25993e+07 6812 1.67936e+07 6988 6.30784e+06 5761.67 1.67936e+07 5755.45 1.67936e+07 3977.18 1.67936e+07 829913 1.18447e+06 8.14194e+06 3.07286e+07 28034 2.30851e+07 nan nan nan nan nan nan nan nan
78372 20231103.8 90924.9 0.811727 17281.7 45628 48368.5 53990.3 4355.3 17137.4 19422.4 14922.2 14674.6 10171.6 44113 5578.73 8.59996e+07 13977.9 1.88908e+07 14087 1.05021e+07 15549.8 1.25993e+07 1424.7 1.25993e+07 6788.55 1.88908e+07 6925.3 6.30784e+06 5793.13 1.67936e+07 5490.55 1.88908e+07 3975.67 1.67936e+07 838885 1.18174e+06 8.15439e+06 3.16504e+07 27795.9 2.30851e+07 nan nan nan nan nan nan nan nan
78384 20231103.12 74382.9 0.802159 17108.5 43878.6 47871.9 52246 4407.6 17039.1 19823.6 17407.9 14732.2 10283.4 45856.3 5517.44 8.59996e+07 13977 1.88908e+07 14136.3 1.05021e+07 15467.4 1.46964e+07 1436.3 1.05021e+07 6845.18 1.88908e+07 6873 6.30784e+06 5794.5 1.67936e+07 5481.25 1.67936e+07 3986.29 1.67936e+07 827005 1.1842e+06 8.15429e+06 3.09913e+07 27988.7 2.30851e+07 nan nan nan nan nan nan nan nan
78407 20231103.18 59381.6 0.797156 17161.2 43521.6 46519.9 53186.1 4343 16972 19625.2 14970 14529.4 10096.1 40541.7 5591.14 8.59996e+07 13982.6 1.88908e+07 14162.3 1.05021e+07 15482.2 1.25993e+07 1429.7 1.25993e+07 6854.13 1.67936e+07 7087.8 6.30784e+06 5753.69 1.67936e+07 5469.17 1.67936e+07 3986.36 1.67936e+07 829355 1.18365e+06 8.17382e+06 3.16191e+07 28323.1 2.30851e+07 nan nan nan nan nan nan nan nan
78430 20231106.1 75314.2 0.785044 17142.7 45699 47880.3 54141.9 4390.8 17165.6 19773.4 15067.1 14805.8 10259.9 45223.5 5655.91 8.59996e+07 14049.4 1.88908e+07 14103.2 1.05021e+07 15592 1.46964e+07 1438.6 1.05021e+07 6904.68 1.88908e+07 7080.2 6.30784e+06 5768.13 1.67936e+07 5444.99 1.67936e+07 4003.81 1.67936e+07 830876 1.1802e+06 8.13838e+06 3.08745e+07 27904 2.30851e+07 nan nan nan nan nan nan nan nan
78447 20231107.4 63226 0.803997 17233.7 43850.9 46545.8 53892.3 4342.9 16914.1 19725.8 17400.6 14863.8 10109.8 43312.1 5657.58 8.59996e+07 14082.8 1.67936e+07 14226.4 1.05021e+07 15619.5 1.46964e+07 1439.7 1.25993e+07 7269.63 1.67936e+07 7062.6 6.30784e+06 5804.83 1.67936e+07 5742.73 1.67936e+07 3981.14 1.67936e+07 834561 1.18331e+06 8.16776e+06 3.07268e+07 27883.9 2.30851e+07 nan nan nan nan nan nan nan nan
78486 20231107.16 87344 0.801874 17279.4 43772.2 47733.8 54072.7 4379 16987.8 19100.7 15027.3 14993.4 10303.6 44144 5617.84 8.59996e+07 14085.9 1.88908e+07 14206.9 1.05021e+07 15610.5 1.46964e+07 1438 1.25993e+07 6857.21 1.88908e+07 6977.6 6.30784e+06 5803.25 1.67936e+07 5736.63 1.67936e+07 3971.58 1.67936e+07 838496 1.18042e+06 8.15371e+06 2.9949e+07 27770.8 2.51822e+07 131 1.97092e+06 nan nan nan nan nan nan
78494 20231108.1 80711.6 0.78468 17313.3 45642.2 47648.1 54269.5 4387.4 17062.1 19037.5 15166.2 15030.2 10352.8 41476.9 5532.27 8.59996e+07 13978.1 1.67936e+07 14115.2 1.05021e+07 15527.7 1.25993e+07 1433.1 1.25993e+07 6857.9 1.88908e+07 6971.4 6.30784e+06 5796.65 1.67936e+07 5489.21 1.67936e+07 3996.02 1.67936e+07 804898 1.17648e+06 8.09413e+06 3.07706e+07 27924.2 2.51822e+07 124 1.97092e+06 nan nan nan nan nan nan
78534 20231108.16 71362 0.814001 17305.2 43733.1 47228.6 53728.9 4372.2 17222.8 19593.2 14958.9 14561.2 10207.8 43059 5508.65 8.59996e+07 14045.8 1.67936e+07 14093.1 1.05021e+07 15472.9 1.46964e+07 1417.5 1.25993e+07 6760.42 1.67936e+07 7034.2 6.30784e+06 5797.13 1.67936e+07 5482.75 1.67936e+07 3994.88 1.67936e+07 834726 1.17855e+06 8.17421e+06 3.284e+07 27940.7 2.51822e+07 127 1.97092e+06 412 1.17179e+07 229 5.94846e+06 nan nan
78546 20231108.20 70955 0.803831 17193.3 45583.3 47085.4 53757.4 4369.1 17214.2 19185.4 17445.6 14796.9 10162.5 43053.4 5562.49 8.59996e+07 13953.9 1.88908e+07 13971.1 1.05021e+07 15327 1.46964e+07 1401.6 1.25993e+07 6825.09 1.88908e+07 6884.7 6.30784e+06 5756.81 1.67936e+07 5462.49 1.67936e+07 3947.94 1.67936e+07 834314 1.17795e+06 8.1518e+06 3.07434e+07 27842.3 2.30851e+07 132 1.97092e+06 423 1.17179e+07 222 5.94846e+06 nan nan
78558 20231108.24 87493 0.791062 17037.4 43865.1 47170 52802.9 4353.3 17050 18865.8 17186.9 14777.5 10241.2 41786.3 5555.81 8.59996e+07 14017.9 1.88908e+07 14164.4 1.05021e+07 15546.1 1.46964e+07 1433.9 1.25993e+07 6787.99 1.67936e+07 6940.2 6.30784e+06 5809.33 1.67936e+07 5447.34 1.67936e+07 3968.11 1.67936e+07 834125 1.18208e+06 8.1247e+06 3.0595e+07 27852.3 2.30851e+07 120 1.97092e+06 398 1.17179e+07 224 5.94846e+06 nan nan
78568 20231109.3 87721.9 0.799269 17264.6 43783.2 47435.4 53481.3 4385.9 17091 19520.6 14848.6 14708.1 10132.6 44947.9 5598.12 8.59996e+07 14087.6 1.88908e+07 14194.3 1.05021e+07 15680 1.46964e+07 1434.2 1.25993e+07 7226.55 1.67936e+07 7100.8 6.30784e+06 5793.83 1.67936e+07 5483.14 1.67936e+07 3971.48 1.67936e+07 834758 1.18204e+06 8.14421e+06 3.08257e+07 27939.1 2.51822e+07 139 1.97092e+06 428 1.17179e+07 238 5.94846e+06 nan nan
78597 20231110.2 89644 0.820217 17438.9 45782.2 48199 54129.5 4406.4 17319.5 19699.8 14922.9 14864.4 10196.3 45165.9 5574.8 8.59996e+07 14024.1 1.88908e+07 14119.9 1.05021e+07 15507.8 1.46964e+07 1421.1 1.25993e+07 7248.55 1.67936e+07 7079.1 6.30784e+06 5793.81 1.67936e+07 5494.3 1.67936e+07 3999.09 1.67936e+07 835013 1.18481e+06 8.14223e+06 3.07975e+07 28119.2 2.51822e+07 124 1.97092e+06 410 1.17179e+07 227 5.94846e+06 nan nan
78603 20231110.5 73387.6 0.800484 17135.5 43772.8 47530.3 54447 4438.1 17217.2 19690.9 17424.3 15192.4 10204.5 38563.2 5580.74 8.59996e+07 14024.5 1.88908e+07 14134.4 1.05021e+07 15453.5 1.46964e+07 1435.7 1.25993e+07 7234.68 1.67936e+07 6947 6.30784e+06 5801.75 1.67936e+07 5489.21 1.67936e+07 4002.28 1.67936e+07 834638 1.17761e+06 8.0415e+06 3.07975e+07 28155.1 2.30851e+07 122 1.97092e+06 414 1.17179e+07 227 5.94846e+06 nan nan
78616 20231110.10 80935.3 0.803176 17222.8 43599.4 47949.9 53841.8 4400.4 17024.2 19096.7 15032.3 14891.5 10161.5 43058 5620.57 8.59996e+07 14024.6 1.88908e+07 14178.4 1.05021e+07 15586.9 1.25993e+07 1421.1 1.25993e+07 6883.97 1.88908e+07 7094.6 6.30784e+06 5767.02 1.67936e+07 5739.27 1.67936e+07 3985.71 1.67936e+07 835116 1.18152e+06 8.15241e+06 3.07646e+07 27789.4 2.51822e+07 124 1.97092e+06 411 1.17179e+07 227 5.94846e+06 nan nan
78639 20231110.19 69445.7 0.781922 17359.9 45728.6 48073.9 54500.8 4431.6 17027.1 19186.5 17302.6 14918.9 10196.6 43277.5 5627.55 8.59996e+07 14013.2 1.88908e+07 14116.4 1.05021e+07 15570.1 1.46964e+07 1433.9 1.25993e+07 6786.6 1.88908e+07 7029.2 6.30784e+06 5799.06 1.67936e+07 5444.62 1.67936e+07 3992.6 1.67936e+07 825457 1.18272e+06 8.08601e+06 3.06931e+07 27614.7 2.30851e+07 113 1.97092e+06 378 1.15766e+07 210 5.93588e+06 nan nan
78665 20231110.28 78278.4 0.829089 17261.7 43577 47253.6 53692.9 4381.6 17122.1 19584.8 17455.2 14674.7 10149.5 34232.3 5521.39 8.59996e+07 13953.4 1.67936e+07 14022.3 1.05021e+07 15426.4 1.46964e+07 1419.1 1.25993e+07 6850.16 1.88908e+07 6826.1 6.30784e+06 5759.17 1.67936e+07 5468.42 1.67936e+07 3980.3 1.67936e+07 834429 1.18129e+06 8.12782e+06 2.99599e+07 27942.5 2.30851e+07 116 1.97092e+06 366 1.15766e+07 217 5.93588e+06 2416 403
78675 20231113.1 85964 0.772318 17202.4 43696.7 47707.9 54236.9 4382.9 17139.4 19492.8 17411.1 14847.1 10307.4 40992.2 5608.64 8.59996e+07 14062 1.88908e+07 14142.3 1.05021e+07 15671.4 1.46964e+07 1433.4 1.05021e+07 7255.39 1.67936e+07 7047.1 6.30784e+06 5802 1.67936e+07 5740.22 1.67936e+07 4009.3 1.67936e+07 836904 1.1866e+06 8.15861e+06 3.08281e+07 28037.5 2.30851e+07 115 1.97092e+06 380 1.15766e+07 212 5.93588e+06 2538 403
78691 20231113.9 71746.7 0.791184 17369 43715 47183.2 50236.1 4411.9 16973.5 19099.3 17221 14850.3 10152.1 42889.5 5691.43 8.59996e+07 14078.8 1.67936e+07 14181.9 1.05021e+07 15617.9 1.25993e+07 1436.5 1.25993e+07 6928.05 1.88908e+07 6981.4 6.30784e+06 5791.47 1.67936e+07 5496.97 1.67936e+07 3962.59 1.67936e+07 826371 1.18244e+06 8.15452e+06 3.08192e+07 27756.8 2.30851e+07 112 1.97092e+06 376 1.15766e+07 201 5.93588e+06 2455 403
78718 20231114.3 88592.2 0.782935 17427.3 43641.3 47441 52857.6 4347.2 17193.3 19138 17301.2 14671.5 10269.8 47160.2 5589.97 8.59996e+07 14046.4 1.88908e+07 14161.3 1.05021e+07 15640.9 1.46964e+07 1431.6 1.25993e+07 6892.85 1.88908e+07 6934.4 6.30784e+06 5793.59 1.67936e+07 5489.05 1.67936e+07 3993.35 1.67936e+07 834060 1.18011e+06 8.13189e+06 3.12071e+07 27951.7 2.30851e+07 123 1.97092e+06 401 1.15766e+07 217 5.93588e+06 2492 403

authenticate_recovery_share_submission

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_mt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem tpcc_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_sim_traces tlc_sim_levelmean
78702 20231113.11 27894 2.30851e+07 0.805653 5531.91 8.59996e+07 74321 13971.3 1.88908e+07 14094.1 1.05021e+07 15534.9 1.46964e+07 17224.4 1433.3 1.25993e+07 45805.5 6875.74 1.88908e+07 49532.7 7034 6.30784e+06 54220.4 4374.2 5766.3 1.67936e+07 17181 19456.8 5479.78 1.67936e+07 17506 14993.1 3993.11 1.67936e+07 10415.5 116 1.97092e+06 384 1.15766e+07 212 5.93588e+06 44690.4 833064 1.18233e+06 8.14301e+06 3.06449e+07 2397 403
78728 20231114.7 28131.2 2.30851e+07 0.817106 5600.83 8.59996e+07 84002.6 13989.7 1.88908e+07 14112.5 1.05021e+07 15551.4 1.25993e+07 17174.3 1431.1 1.25993e+07 45779.7 7193.28 1.67936e+07 48461.8 6916.3 6.30784e+06 53642.3 4396 5783.89 1.67936e+07 17193.2 18999.5 5435.24 1.67936e+07 17357.3 14720 3986.14 1.67936e+07 10263.9 119 1.97092e+06 378 1.15766e+07 206 5.93588e+06 41783.6 838598 1.18881e+06 8.12627e+06 3.07e+07 2520 403

images

@achamayou achamayou changed the title Authenticate_recovery_share_submission Authenticate recovery share submission Nov 14, 2023
@achamayou achamayou merged commit 583fab2 into microsoft:main Nov 14, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The /recovery/members/{memberId}:recover endpoint in the 2023-06-01-preview API is unauthenticated
3 participants