Use a hard-coded string for virtual measurement#6802
Merged
achamayou merged 2 commits intoFeb 4, 2025
Conversation
achamayou
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously calling
uname -a, which includes node name, which obviously differs across real networked/containerised nodes.We could call something that will be common across nodes (
uname -s -r), but I think this is an unnecessary risk - it still means we may get virtual nodes refusing to join because they are running in different environments, and doesn't actually get us any benefit. This call tounamewas used so that we could add a shim to modify it without using a custom envvar/additional config value, but we don't actually have a use for modifying it. We test that measurement policy is applied by removing the trusted measurement, rather than starting a node with an alternative measurement. Shipping anything that modifies it (aunamebash script shim, or some separate script to be called) alongsidecchostis awkward even within our test infra.If we ever have a use case for modifying the measurement, we can revisit.