Fixed issue with CodeFormatter script not calling out all the rules#688
Merged
Conversation
By having this defined, we override the value `IncludeDefaultRules = $true`
No need to have the functions in Shared till they are used by other scripts.
…essMessageAttribute
placing into a process/end block didn't help
To allow the branch to be merged in. Follow updates in #687
dpaulson45
requested review from
bill-long,
erinIs1337,
ethanb-msft and
lusassl-msft
as code owners
bill-long
requested changes
Aug 9, 2021
bill-long
previously approved these changes
Aug 9, 2021
bill-long
force-pushed
the
dpaul-CodeFormatterFix
branch
from
8d3ce03 to
deb6495
Compare
bill-long
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the IncludeRules section of the
PSScriptAnalyzerSettings.psd1file and addressed all the rules that were now being flagged for all the scriptsResolved #682