Skip to content

Wording fixed#691

Merged
lusassl-msft merged 2 commits into
mainfrom
lusassl-wordingfix
Aug 12, 2021
Merged

Wording fixed#691
lusassl-msft merged 2 commits into
mainfrom
lusassl-wordingfix

Conversation

@lusassl-msft
Copy link
Copy Markdown
Contributor

@lusassl-msft lusassl-msft commented Aug 11, 2021

Test-ScriptVersion returns $false if the version is current and no script update is required or when we run into a state where no update can be performed (for example due to no internet access).

Reason:
Due to the way how Test-ScriptVersion works, we cannot distinguish what the reason for a non-update state is. The wording was adjusted to highlight that no update was performed which might be by design (version current).
Long term resolution would be to adjust Test-ScriptVersion to differentiate between a successful update, no update required or no update possible and return the appropriate value.

@bill-long
Copy link
Copy Markdown
Member

My original use of the result value from Test-ScriptVersion was just so the caller could say "Do I need to restart the script due to an update, or not?" I'm not sure if the caller needs any more information than that.

@lusassl-msft
Copy link
Copy Markdown
Contributor Author

Thanks Bill. Doesn’t have a high prio. Will think about it later. We should be good for the moment with the current approach.

@lusassl-msft lusassl-msft merged commit 90d912b into main Aug 12, 2021
@lusassl-msft lusassl-msft deleted the lusassl-wordingfix branch August 12, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants