Wording fixed#691
Merged
Merged
Conversation
… lusassl-wordingfix
Member
|
My original use of the result value from Test-ScriptVersion was just so the caller could say "Do I need to restart the script due to an update, or not?" I'm not sure if the caller needs any more information than that. |
bill-long
approved these changes
Aug 11, 2021
Contributor
Author
|
Thanks Bill. Doesn’t have a high prio. Will think about it later. We should be good for the moment with the current approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-ScriptVersionreturns$falseif the version is current and no script update is required or when we run into a state where no update can be performed (for example due to no internet access).Reason:
Due to the way how
Test-ScriptVersionworks, we cannot distinguish what the reason for a non-update state is. The wording was adjusted to highlight that no update was performed which might be by design (version current).Long term resolution would be to adjust
Test-ScriptVersionto differentiate between a successful update, no update required or no update possible and return the appropriate value.