Skip to content

Add new condition to DL2365Groupupgrade script #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bill-long merged 2 commits into from
Aug 15, 2021
Merged

Add new condition to DL2365Groupupgrade script #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
439576a
Merge branch 'main' of https://github.com/microsoft/CSS-Exchange
hazemembaby Aug 15, 2021
11a710b
remove commented lines
hazemembaby Aug 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions M365/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# [DLT365Groupsupgrade.ps1](https://github.com/microsoft/CSS-Exchange/releases/latest/download/DLT365Groupsupgrade.ps1)

## Validating Distribution group eligibility for upgrade to O365 Group
## Validating Distribution group eligibility for upgrade to Microsoft 365 Group

This script allows you to check Distribution to O365 Group migration eligibility for a specific distribution group SMTP, for more information over the Distribution to O365 Group migration blockers please check: https://docs.microsoft.com/en-us/microsoft-365/admin/manage/upgrade-distribution-lists?view=o365-worldwide
This script allows you to check Distribution to Microsoft 365 Group migration eligibility for a specific distribution group SMTP, for more information over the Distribution to Microsoft 365 Group migration blockers please check: https://docs.microsoft.com/en-us/microsoft-365/admin/manage/upgrade-distribution-lists?view=o365-worldwide

Download the latest release here: [https://github.com/microsoft/CSS-Exchange/releases/latest/download/DLT365Groupsupgrade.ps1](https://github.com/microsoft/CSS-Exchange/releases/latest/download/DLT365Groupsupgrade.ps1)

Expand Down
50 changes: 43 additions & 7 deletions M365/src/DLT365Groupsupgrade.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Function Connect2EXO {
} else {
#log failure and try to install EXO V2 module then Connect to EXO
Write-Host "ExchangeOnlineManagement Powershell Module is missing `n Trying to install the module" -ForegroundColor Red
Install-Module -Name ExchangeOnlineManagement -Force -ErrorAction Stop
Install-Module -Name ExchangeOnlineManagement -Force -ErrorAction Stop -Scope CurrentUser
Import-Module ExchangeOnlineManagement -ErrorAction stop -Force
$CurrentDescription = "Installing & Importing EXO V2 powershell module"
$CurrentStatus = "Success"
Expand Down Expand Up @@ -100,13 +100,13 @@ Function Debugmatchingeap {
$eap = Get-EmailAddressPolicy -ErrorAction stop
# Bypass that step if there's no EAP
if ($null -ne $eap) {
$matchingEap = @( $eap | Where-Object { $_.RecipientFilter -eq "RecipientTypeDetails -eq 'GroupMailbox'" -and $_.EnabledPrimarySMTPAddressTemplate.ToString().Split("@")[1] -ne $Distgroup.PrimarySmtpAddress.ToString().Split("@")[1] })
$matchingEap = @( $eap | Where-Object { $_.RecipientFilter -eq "RecipientTypeDetails -eq 'GroupMailbox'" -and $_.EnabledPrimarySMTPAddressTemplate.ToString().Split("@")[1] -cne $Distgroup.PrimarySmtpAddress.ToString().Split("@")[1] })
if ($matchingEap.Count -ge 1) {
$script:Conditionsfailed++
Write-Host "Distribution Group can't be upgraded because Admin has applied Group Email Address Policy for the groups on the organization" -ForegroundColor Red
Write-Host "Distribution Group can't be upgraded because Admin has applied Group Email Address Policy for the groups on the organization e.g. DL PrimarySmtpAddress @Contoso.com while the EAP EnabledPrimarySMTPAddressTemplate is @contoso.com OR DL PrimarySmtpAddress @contoso.com however there's an EAP with EnabledPrimarySMTPAddressTemplate set to @fabrikam.com" -ForegroundColor Red
Write-Host "Group Email Address Policy found:" -BackgroundColor Yellow -ForegroundColor Black
$matchingEap | Format-Table name, recipientfilter, Guid, enabledemailaddresstemplates
"Distribution Group can't be upgraded because Admin has applied Group Email Address Policy for the groups on the organization" | Out-File $ExportPath\DlToO365GroupUpgradeChecksREPORT.txt -Append
"Distribution Group can't be upgraded because Admin has applied Group Email Address Policy for the groups on the organization e.g. DL PrimarySmtpAddress @Contoso.com while the EAP EnabledPrimarySMTPAddressTemplate is @contoso.com OR DL PrimarySmtpAddress @contoso.com however there's an EAP with EnabledPrimarySMTPAddressTemplate set to @fabrikam.com" | Out-File $ExportPath\DlToO365GroupUpgradeChecksREPORT.txt -Append
"Group Email Address Policy found:" | Out-File $ExportPath\DlToO365GroupUpgradeChecksREPORT.txt -Append
$matchingEap | Format-Table name, recipientfilter, Guid, enabledemailaddresstemplates | Out-File $ExportPath\DlToO365GroupUpgradeChecksREPORT.txt -Append
}
Expand All @@ -132,9 +132,6 @@ Function Debuggroupnesting {
foreach ($parentdg in $alldgs) {
try {
$Pmembers = Get-DistributionGroupMember $($parentdg.Guid.ToString()) -ErrorAction Stop
$CurrentDescription = "Retrieving: $parentdg members"
$CurrentStatus = "Success"
log -Function "Retrieve Distribution Group membership" -CurrentDescription $CurrentDescription -CurrentStatus $CurrentStatus
} catch {
$CurrentDescription = "Retrieving: $parentdg members"
$CurrentStatus = "Failure"
Expand Down Expand Up @@ -208,6 +205,44 @@ Function Debugownerscount {
"Distribution Group can't be upgraded because it has more than 100 owners or it has no owners" | Out-File $ExportPath\DlToO365GroupUpgradeChecksREPORT.txt -Append
}
}
#Check if Distribution Group can't be upgraded because the distribution list owner(s) is non-supported with RecipientTypeDetails other than UserMailbox, MailUser
Function Debugownersstatus {
param(
[Parameter(Mandatory = $true)]
[PScustomobject]$Distgroup
)
$owners = $Distgroup.ManagedBy
if ($owners.Count -le 100 -and $owners.Count -ge 1) {
$ConditionDGownerswithoutMBX = @()
foreach ($owner in $owners) {
try {
$owner = Get-Recipient $owner -ErrorAction stop
$CurrentDescription = "Validating: $owner RecipientTypeDetails"
$CurrentStatus = "Success"
log -Function "Validate owner RecipientTypeDetails" -CurrentStatus $CurrentStatus -CurrentDescription $CurrentDescription
if (!($owner.RecipientTypeDetails -eq "UserMailbox" -or $owner.RecipientTypeDetails -eq "MailUser")) {
$ConditionDGownerswithoutMBX = $ConditionDGownerswithoutMBX + $owner
}
} catch {
$CurrentDescription = "Validating: $owner RecipientTypeDetails"
$CurrentStatus = "Failure"
log -Function "Validate owner RecipientTypeDetails" -CurrentStatus $CurrentStatus -CurrentDescription $CurrentDescription
#Check if the owner RecipientTypeDetails is User
$owner = Get-User $owner -ErrorAction stop
$ConditionDGownerswithoutMBX = $ConditionDGownerswithoutMBX + $owner
}
}
if ($ConditionDGownerswithoutMBX.Count -ge 1) {
Write-Host "Distribution Group can't be upgraded because DL owner(s) is non-supported with RecipientTypeDetails other than UserMailbox, MailUser" -ForegroundColor Red
Write-Host "Non-supported Owner(s) found:" -BackgroundColor Yellow -ForegroundColor Black
$ConditionDGownerswithoutMBX | Format-Table -AutoSize -Wrap Name, GUID, RecipientTypeDetails
"Distribution Group can't be upgraded because DL owner(s) is non-supported with RecipientTypeDetails other than UserMailbox, MailUser" | Out-File $ExportPath\DlToO365GroupUpgradeChecksREPORT.txt -Append
"Non-supported Owner(s) found:" | Out-File $ExportPath\DlToO365GroupUpgradeChecksREPORT.txt -Append
$ConditionDGownerswithoutMBX | Format-Table -AutoSize -Wrap Name, GUID, RecipientTypeDetails | Out-File $ExportPath\DlToO365GroupUpgradeChecksREPORT.txt -Append
$script:Conditionsfailed++
}
}
}
#Check if Distribution Group can't be upgraded because the distribution list is part of Sender Restriction in another DL
Function Debugsenderrestriction {
param(
Expand Down Expand Up @@ -377,6 +412,7 @@ Debugmatchingeap($dg)
Debuggroupnesting($dg)
DebugmembersrecipientTypes($dg)
Debugownerscount($dg)
Debugownersstatus($dg)
Debugsenderrestriction($dg)
Debuggrouprecipienttype($dg)
Debugforwardingforsharedmbxs($dg)
Expand Down