Skip to content
Permalink
Browse files

[MERGE #6272 @rhuanjl] ModuleEvaluation should return undefined

Merge pull request #6272 from rhuanjl:moduleReturnUndefined

Picking up on discussion in #6266 this reverts an unintended side-effect of #6171

The successful completion value of a module is `undefined` - this was not tested and the change in #6171 had resulted in it being  `{done : true}` instead.
  • Loading branch information...
Kevin Smith
Kevin Smith committed Sep 10, 2019
2 parents e79d68a + bcde2bd commit 062ef9f970fc7e387d7a7ce90217a37ddb07c2c8
Showing with 1 addition and 0 deletions.
  1. +1 −0 lib/Runtime/Language/SourceTextModuleRecord.cpp
@@ -1103,6 +1103,7 @@ namespace Js
{
ResumeYieldData yieldData(scriptContext->GetLibrary()->GetUndefined(), nullptr);
ret = gen->CallGenerator(&yieldData, _u("Module Global"));
ret = JavascriptOperators::GetProperty(VarTo<RecyclableObject>(ret), PropertyIds::value, scriptContext);
}
END_SAFE_REENTRANT_CALL
}

0 comments on commit 062ef9f

Please sign in to comment.
You can’t perform that action at this time.