Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding build status badges to the README.md #63

Merged
merged 2 commits into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@tannergooding
Copy link
Member

commented Jun 6, 2019

This also fixes up some issues that were preventing CI from running.

@@ -98,31 +98,24 @@ public enum MyEnum : {expectedManagedType}
await ValidateGeneratedBindings(inputContents, expectedOutputContents);
}

[Fact]
public async Task NoDefinitionTest()

This comment has been minimized.

Copy link
@tannergooding

tannergooding Jun 6, 2019

Author Member

Clang 5 reports this as a "Microsoft Extension" and doesn't actually add a declaration for the enum so it results in no codegen.

This comment has been minimized.

Copy link
@tannergooding

tannergooding Jun 6, 2019

Author Member

(specifically it marks forward declarations of enums as a "Microsoft Extension")

@mjsabby

mjsabby approved these changes Jun 6, 2019

@tannergooding tannergooding force-pushed the tannergooding:ci branch from f3bf35b to d2237b9 Jun 6, 2019

@@ -9,7 +9,7 @@ public sealed class EnumDeclarationTest : PInvokeGeneratorTest
[Fact]
public async Task BasicTest()
{
var inputContents = @"enum MyEnum
var inputContents = @"enum MyEnum : int

This comment has been minimized.

Copy link
@tannergooding

tannergooding Jun 6, 2019

Author Member

Unix defaults to : uint, marking it explicitly int so tests pass for now.

@@ -110,16 +110,19 @@ try {
Create-Directory -Path $LogDir

if ($architecture -ne "") {
$DOTNET_SKIP_FIRST_TIME_EXPERIENCE = 1
$env:DOTNET_CLI_TELEMETRY_OPTOUT = 1

This comment has been minimized.

Copy link
@tannergooding

tannergooding Jun 6, 2019

Author Member

This wasn't be respected if it wasn't properly exported. Will also submit a fix for LLVMSharp.

@@ -100,6 +100,7 @@ public static int Run(InvocationContext context)

var clangCommandLineArgs = new string[]
{
"-std=c++11", // The input files should be compiled for C++ 11

This comment has been minimized.

Copy link
@tannergooding

tannergooding Jun 6, 2019

Author Member

Clang 5 (which is currently being used for tests) doesn't target C++11 by default yet.

@tannergooding tannergooding merged commit 2740afe into microsoft:master Jun 6, 2019

8 checks passed

license/cla All CLA requirements met.
Details
microsoft.ClangSharp Build #20190606.5 succeeded
Details
microsoft.ClangSharp (ubuntu_1604_debug_x64) ubuntu_1604_debug_x64 succeeded
Details
microsoft.ClangSharp (ubuntu_1604_release_x64) ubuntu_1604_release_x64 succeeded
Details
microsoft.ClangSharp (windows_debug_x64) windows_debug_x64 succeeded
Details
microsoft.ClangSharp (windows_debug_x86) windows_debug_x86 succeeded
Details
microsoft.ClangSharp (windows_release_x64) windows_release_x64 succeeded
Details
microsoft.ClangSharp (windows_release_x86) windows_release_x86 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.