Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing `runtime.rid.libclang` to be `libclang.runtime.rid` #67

Merged
merged 1 commit into from Jun 8, 2019

Conversation

Projects
None yet
2 participants
@tannergooding
Copy link
Member

commented Jun 7, 2019

The runtime prefix is reserved by nuget.

@tannergooding tannergooding force-pushed the tannergooding:ci branch from 352a1d3 to 9c2723f Jun 7, 2019

@@ -27,7 +27,7 @@

<!-- Package versions for package references across all projects -->
<ItemGroup>
<PackageReference Update="libClang" Version="5.0.0" NoWarn="NU1701" />
<PackageReference Update="libclang" Version="8.0.0" />

This comment has been minimized.

Copy link
@tannergooding

tannergooding Jun 7, 2019

Author Member

Also updated this to use the new package.

This comment has been minimized.

Copy link
@tannergooding

tannergooding Jun 8, 2019

Author Member

Dropped this so I can put it in it's own PR and not block fixing the nuspecs.

@tannergooding

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

Will determine what dependency the ubuntu CI machines are missing later tonight.

@mjsabby

mjsabby approved these changes Jun 7, 2019

@tannergooding tannergooding force-pushed the tannergooding:ci branch from 0450673 to 9c2723f Jun 8, 2019

@tannergooding tannergooding merged commit 94b7db1 into microsoft:master Jun 8, 2019

10 checks passed

license/cla All CLA requirements met.
Details
microsoft.ClangSharp Build #20190608.1 succeeded
Details
microsoft.ClangSharp (macos_1014_debug_x64) macos_1014_debug_x64 succeeded
Details
microsoft.ClangSharp (macos_1014_release_x64) macos_1014_release_x64 succeeded
Details
microsoft.ClangSharp (ubuntu_1604_debug_x64) ubuntu_1604_debug_x64 succeeded
Details
microsoft.ClangSharp (ubuntu_1604_release_x64) ubuntu_1604_release_x64 succeeded
Details
microsoft.ClangSharp (windows_debug_x64) windows_debug_x64 succeeded
Details
microsoft.ClangSharp (windows_debug_x86) windows_debug_x86 succeeded
Details
microsoft.ClangSharp (windows_release_x64) windows_release_x64 succeeded
Details
microsoft.ClangSharp (windows_release_x86) windows_release_x86 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.