Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always write headers and check against empty paths #80

Merged
merged 3 commits into from Aug 10, 2019

Conversation

@FiniteReality
Copy link
Contributor

commented Aug 8, 2019

This fixes #78 and fixes #79. Header files are written whenever a valid header file is passed, and null/empty paths are now ignored.

Sorry about the whitespace changes, I didn't realise I had VS Code set to hide whitespace changes in git diffs.

Always write headers and check against empty paths
This fixes #78 and fixes #79. Header files are written whenever a valid
header file is passed, and null/empty paths are now ignored.
@msftclas

This comment has been minimized.

Copy link

commented Aug 8, 2019

CLA assistant check
All CLA requirements met.

Skip generating the header in the method class
It was already written earlier, so it is unnecessary.
if (name.Equals("param"))
{
_outputBuilder.Write(index);
}

This comment has been minimized.

Copy link
@tannergooding

tannergooding Aug 8, 2019

Member

👍, the formatter should have removed this and it shouldn't have been committed in the first place

@tannergooding

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Test failures for windows look unrelated. Looks like something might've changed with how paths are processed....

@tannergooding

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

@tannergooding tannergooding merged commit 57c618b into microsoft:master Aug 10, 2019

10 checks passed

license/cla All CLA requirements met.
Details
microsoft.ClangSharp Build #20190810.4 succeeded
Details
microsoft.ClangSharp (macos_debug_x64) macos_debug_x64 succeeded
Details
microsoft.ClangSharp (macos_release_x64) macos_release_x64 succeeded
Details
microsoft.ClangSharp (ubuntu_debug_x64) ubuntu_debug_x64 succeeded
Details
microsoft.ClangSharp (ubuntu_release_x64) ubuntu_release_x64 succeeded
Details
microsoft.ClangSharp (windows_debug_x64) windows_debug_x64 succeeded
Details
microsoft.ClangSharp (windows_debug_x86) windows_debug_x86 succeeded
Details
microsoft.ClangSharp (windows_release_x64) windows_release_x64 succeeded
Details
microsoft.ClangSharp (windows_release_x86) windows_release_x86 succeeded
Details

@FiniteReality FiniteReality deleted the FiniteReality:fix-header-files branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.