Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple workbox bundles to allowed packages #583

merged 2 commits into from Dec 28, 2022


Copy link

@NivaldoFarias NivaldoFarias commented Dec 22, 2022

Resolving the issue mentioned at the workbox-build PR.

Copy link

Are all of these direct dependencies of something in DT? Transitive dependencies don’t need to be listed.

Copy link
Contributor Author

NivaldoFarias commented Dec 23, 2022

Are all of these direct dependencies of something in DT? Transitive dependencies don’t need to be listed.

Yes, unfortunately enough. Though that got me thinking, since the dependencies at DT workbox-sw@4.3.2 points to other workbox-_ DT packages (most are at @4.3.2 aswell) that will be removed in favour of newer and bundled types by the original package, then this may be a case (as mentioned in DT's README) of adding the removed @types/workbox-_ packages to the dependencies list.

Then, the right solution would be to add the @types/ packages instead of the original ones to the allowed packages .txt file. If this is correct and is approved, I will update both PRs.

@@ -749,6 +749,19 @@
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to reference the type declarations used inside the DT customize-cra and workbox-sw packages, all of these @types/ packages need to be included in the allowed packages list. The dependencies inside the mentioned DT packages refer to older, to-be-removed DT workbox-_ packages.

see PR to remove old workbox-_ packages

@sandersn sandersn merged commit e7e4377 into microsoft:master Dec 28, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants