Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetResourceFromHeap. #2691

Merged
merged 7 commits into from Feb 13, 2020
Merged

Add GetResourceFromHeap. #2691

merged 7 commits into from Feb 13, 2020

Conversation

python3kgae
Copy link
Contributor

@python3kgae python3kgae commented Feb 11, 2020

Add GetResourceFromHeap for hlsl.
For Dxil, add CreateHandleFromHeap and AnnotateHandle.

All handles ( createHandle, createHandleForLib, createHandleFromHeap ) must be annotated with AnnotateHandle before use.

TODO: add AnnotateHandle for pix passes.

Xiang Li added 4 commits Feb 9, 2020
Add GetResourceFromHeap to clang.
719dcf7
Add HL codegen for HLAnnotateHandle and lowerGetResourceFromHeap.
89d473e
Add dxil codegen for createHandleFromHeap and annotateHandle.
fbd29d3 
Now every createHandle, createHandleForLib, createHandleFromHeap will be used only by annotateHandle.
TODO: fix place iterate on users of createHandle/createHandleForLib for handle usage.
      Now it should iterate on users of annotateHandle.
Support handle from annotateHandle.
e47bf03
@python3kgae python3kgae requested a review from tex3d Feb 11, 2020
tex3d
tex3d reviewed Feb 11, 2020
View changes
utils/hct/hctdb.py Outdated Show resolved Hide resolved
tex3d
tex3d reviewed Feb 11, 2020
View changes
utils/hct/hctdb.py Show resolved Hide resolved
tex3d
tex3d reviewed Feb 11, 2020
View changes
utils/hct/hctdb.py Outdated Show resolved Hide resolved
tex3d
tex3d reviewed Feb 11, 2020
View changes
tools/clang/lib/CodeGen/CGHLSLMS.cpp Outdated Show resolved Hide resolved
tex3d
tex3d reviewed Feb 11, 2020
View changes
tools/clang/lib/CodeGen/CGHLSLMS.cpp Outdated Show resolved Hide resolved
tex3d
tex3d reviewed Feb 11, 2020
View changes
lib/HLSL/HLOperationLower.cpp Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Feb 11, 2020

❌ Build DirectXShaderCompiler 1.0.2708 failed (commit cb86a65cfc by @)

tex3d
tex3d reviewed Feb 11, 2020
View changes
lib/DXIL/DxilResourceProperties.cpp Outdated Show resolved Hide resolved
tex3d
tex3d reviewed Feb 11, 2020
View changes
lib/DXIL/DxilResourceProperties.cpp Outdated Show resolved Hide resolved
Xiang Li added 2 commits Feb 13, 2020
tex3d
tex3d reviewed Feb 13, 2020
View changes
tools/clang/lib/Sema/SemaHLSL.cpp Outdated Show resolved Hide resolved
tex3d
tex3d approved these changes Feb 13, 2020
View changes
@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Feb 13, 2020

✅ Build DirectXShaderCompiler 1.0.2712 completed (commit d4e758ae09 by @)

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Feb 13, 2020

✅ Build DirectXShaderCompiler 1.0.2715 completed (commit d4fbf4528b by @)

@python3kgae python3kgae merged commit 91fe12f into microsoft:master Feb 13, 2020
3 checks passed
@python3kgae python3kgae mentioned this pull request Feb 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tex3d tex3d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@python3kgae @AppVeyorBot @tex3d