This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Adopt theme in newly created windows automatically #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
Let's break down the task into pieces. This PR is ready now. @zhuorantan @li-bei do you have the bandwidth to review this PR? |
imWildCat
reviewed
Jun 28, 2020
| window?.makeKeyAndVisible() | ||
|
|
||
| return true | ||
| } | ||
|
|
||
| class func createNewWindow(with window: UIWindow) -> UIWindow { |
There was a problem hiding this comment.
Question: should we use static? Which should we prefer?
There was a problem hiding this comment.
makes little difference here, but probably static is preferred because static func cannot be overridden in subclass whereas class func can
There was a problem hiding this comment.
IMO, it would be better to choose static over class whenever possible. I think Swift prefers static. There might be a best practice for this.
There was a problem hiding this comment.
let's go ahead with static here.
use static func wherever possible
li-bei
approved these changes
Jun 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observe UIWindowDidBecomeVisibleNotification notification, and apply theme to the window, since it is possible to just create a UIWindow and make it key/visible without using UIScene API.
The example app is also updated with multi-window support on iPad.