Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The assert polyfill is needed when using InsecureTokenProvider #11350

Closed
Tracked by #9508
tylerbutler opened this issue Jul 29, 2022 · 2 comments · Fixed by #11868
Closed
Tracked by #9508

The assert polyfill is needed when using InsecureTokenProvider #11350

tylerbutler opened this issue Jul 29, 2022 · 2 comments · Fixed by #11868
Labels
area: dev experience Improving the experience of devs building on top of fluid

Comments

@tylerbutler
Copy link
Member

tylerbutler commented Jul 29, 2022 •
edited

PR #10488 added a dependency on the node "assert" package in test-runtime-utils. That package contains InsecureTokenProvider, which is used in many demos and samples in the browser, so the assert dep introduces the need for a polyfill.

The assert polyfill is quite large and we should avoid requiring it.
@tylerbutler tylerbutler mentioned this issue Jul 29, 2022
Closed
4 tasks
@msftbot msftbot bot added the triage label Jul 29, 2022
@tylerbutler tylerbutler added area: dev experience Improving the experience of devs building on top of fluid and removed triage labels Jul 29, 2022
@zhonglin94
Copy link

I face the same problem. Is there any workaround to fix this in Angular 12 projects?

This was referenced Sep 8, 2022
Closed
Merged
Merged
tylerbutler added a commit that referenced this issue Sep 8, 2022
@tylerbutler
[lint-config] Enable import/no-nodejs-modules rule (#11870)
9266604 
Related to #11350. This lint rule helps prevent taking dependencies on
node libraries, and given our browser-first focus, we should enable it
in our default config. I made it a warning to make it easier to adopt.
@tylerbutler
Copy link
Member Author

The fix for this should be in upcoming version 1.2.6 and 2.0.0-internal.1.2.0.

@tylerbutler tylerbutler mentioned this issue Oct 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: dev experience Improving the experience of devs building on top of fluid
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[test-runtime-utils] Rm node assert library dep microsoft/FluidFramework
2 participants
@tylerbutler @zhonglin94