Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinylicious reuses state in temp folder between processes #5988

Closed
rsullivan00 opened this issue Apr 29, 2021 · 7 comments
Closed

Tinylicious reuses state in temp folder between processes #5988

rsullivan00 opened this issue Apr 29, 2021 · 7 comments
Assignees
Labels
area: server Server related issues (routerlicious) documentation Improvements or additions to documentation feature-request New feature or requests status: stale

Comments

@rsullivan00
Copy link

Issue Category

Details

Tinylicious seems to not actually run "in memory" in the way I would interpret that part of the documentation. When I:

  • Run npx tinylicious (runs version tinylicious@0.4.21640)
  • Add some data to a connection
  • Copy one of the GET requests for a commit
  • Stop the tinylicious process
  • Restart the tinylicous process
  • Resend the copied commit GET request

I would expect the data to no longer exist in the new process, but it does, I assume because I can find the commit in /var/tmp/tinylicious.

$ ls /var/tmp/tinylicious/tinylicious/.git/objects/7b/09ae11e428ecadcd9fe0779562ef04cafd18e8
/var/tmp/tinylicious/tinylicious/.git/objects/7b/09ae11e428ecadcd9fe0779562ef04cafd18e8

I'm assuming this is a documentation ambiguity, but it's possible this is a bug. Is this the intended behavior for Tinylicious?

I have been manually deleting /var/tmp/tinylicious between restarts to start from an empty state, which is cumbersome and unexpected from how I interpreted the README. I checked that the behavior is the same on Powershell as well as WSL2 + Ubuntu 20.

@rsullivan00 rsullivan00 added the documentation Improvements or additions to documentation label Apr 29, 2021
@tylerbutler
Copy link
Member

@skylerjokiel Who's the best person to take a look at this?

@kevindiclemente
Copy link

gentle ping on this one

@kevindiclemente
Copy link

kevindiclemente commented Jul 27, 2021

would be nice to have a config option for ephemeral use case for testing

@curtisman
Copy link
Member

Yep. We should clean the storage directory on start up, and only reuse the directory if we using db.inMemory is false.

@curtisman curtisman added feature-request New feature or requests area: server Server related issues (routerlicious) and removed triage labels Aug 25, 2021
@msftbot
Copy link
Contributor

msftbot bot commented Feb 22, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@tylerbutler
Copy link
Member

This should stay open.

@msftbot msftbot bot removed the status: stale label Mar 1, 2022
@msftbot
Copy link
Contributor

msftbot bot commented Aug 28, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@msftbot msftbot bot closed this as completed Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Server related issues (routerlicious) documentation Improvements or additions to documentation feature-request New feature or requests status: stale
Projects
None yet
Development

No branches or pull requests

5 participants