Tree: Field kinds #11469
Merged
Tree: Field kinds #11469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 9, 2022 09:47
github-actions
bot
added
area: dds
added 9 commits
August 11, 2022 15:46
…to filed-kinds
jenn-le
requested changes
Aug 16, 2022
packages/dds/tree/src/feature-libraries/modular-schema/comparison.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jenn <jennle@microsoft.com>
jenn-le
reviewed
Aug 16, 2022
packages/dds/tree/src/feature-libraries/modular-schema/fieldKind.ts
Outdated
Show resolved
Hide resolved
packages/dds/tree/src/feature-libraries/modular-schema/fieldKind.ts
Outdated
Show resolved
Hide resolved
packages/dds/tree/src/feature-libraries/modular-schema/fieldKind.ts
Outdated
Show resolved
Hide resolved
packages/dds/tree/src/feature-libraries/modular-schema/fieldKind.ts
Outdated
Show resolved
Hide resolved
packages/dds/tree/src/feature-libraries/modular-schema/fieldKind.ts
Outdated
Show resolved
Hide resolved
jenn-le
reviewed
Aug 16, 2022
Co-authored-by: Jenn <jennle@microsoft.com>
…to filed-kinds
…nd.ts Co-authored-by: Jenn <jennle@microsoft.com>
jenn-le
approved these changes
Aug 17, 2022
|
This commit is queued for merging with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor FieldKind (as part of field schema) to be an extension for the schema system rather than a close set via an enum.
For all the areas that this impacts are very much in the early proof of concept phase, so this abstraction is not really used, but longer term actual change handlers, edit builders, and even field reading APIs and encoding formats can be dictated by their FieldKind. This should allow for modularizing, versioning and upgrading the policy logic for various field types (such as sequence, value, optional, etc) in the future.
Reviewer Guidance
As this is half architectural work and half tweaking example and proof of concept code to work with it, it's a bit hard to review.
Main things I'd like feedback on are unclear/insufficient high-level documentation, and anything that seems like it could be an architectual mistake (ex: possible cyclic dep, something that will be hard to change later, things that won't be unit testable effectively)