Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IContainerRuntime.flush #11519

Merged
merged 10 commits into from Aug 29, 2022
Merged

Remove IContainerRuntime.flush #11519

merged 10 commits into from Aug 29, 2022

Conversation

kian-thompson
Copy link
Contributor

AB#1076

For more information about how to contribute to this repo, visit this page.

Description

IContainerRuntime.flush was deprecated in a previous version.
It's removal introduces a breaking change. If a more manual flush functionality is needed, migrate all usage to IContainerRuntimeBase.orderSequentially if possible.

@kian-thompson kian-thompson requested review from a team as code owners August 11, 2022 21:19
@github-actions github-actions bot added area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc breaking change This PR or issue would introduce a breaking change public api change Changes to a public API base: next PRs targeted against next branch labels Aug 11, 2022
andre4i
andre4i reviewed Aug 11, 2022
View reviewed changes
BREAKING.md Outdated Show resolved Hide resolved
BREAKING.md Outdated Show resolved Hide resolved
packages/test/local-server-tests/src/test/documentDirty.spec.ts Show resolved Hide resolved
@kian-thompson kian-thompson marked this pull request as draft August 12, 2022 19:20
@kian-thompson
Fix BREAKIN.md
9b16de5
@kian-thompson
Fix unit tests
8369ce6 
- batch metadata is now added regardless if the container is connected (needs this information when replaying Immediate batches)
@kian-thompson
Attempt to fix unit tests
d520730
@github-actions github-actions bot added the area: examples Changes that focus on our examples label Aug 12, 2022
@github-actions github-actions bot removed the area: examples Changes that focus on our examples label Aug 23, 2022
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Aug 23, 2022 •
edited

⯅ @fluid-example/bundle-size-tests: +15.41 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 392.45 KB 393.7 KB ⯅ +1.26 KB
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 191.92 KB 196.43 KB ⯅ +4.5 KB
loader.js 151.12 KB 151.06 KB ⯆ -57 Bytes
map.js 42.63 KB 47.38 KB ⯅ +4.75 KB
matrix.js 131.63 KB 134.98 KB ⯅ +3.35 KB
odspDriver.js 150.23 KB 150.11 KB ⯆ -127 Bytes
odspPrefetchSnapshot.js 38.39 KB 38.35 KB ⯆ -41 Bytes
sharedString.js 152.42 KB 154.2 KB ⯅ +1.77 KB
Total Size 1.25 MB 1.27 MB ⯅ +15.41 KB

Baseline commit: b7b2bd3

Generated by 🚫 dangerJS against 37f84f9

@kian-thompson kian-thompson marked this pull request as ready for review August 23, 2022 23:17
andre4i
andre4i approved these changes Aug 25, 2022
View reviewed changes
BREAKING.md

### Remove ISummaryConfigurationHeuristics.idleTime
`ISummaryConfigurationHeuristics.idleTime` has been removed. See [#10008](https://github.com/microsoft/FluidFramework/issues/10008)
Please move all usage to the new `minIdleTime` and `maxIdleTime` properties in `ISummaryConfigurationHeuristics`.

### Move `TelemetryNullLogger` and `BaseTelemetryNullLogger` to telemetry-utils package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why where these moved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't catch the weird ordering in my last PR into next. These moved items belong under the upcoming changes section

@msftbot
Copy link
Contributor

msftbot bot commented Aug 29, 2022

Hello @kian-thompson!

Because this pull request has the msftbot: merge-next label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@msftbot msftbot bot merged commit d42562d into microsoft:next Aug 29, 2022
@kian-thompson kian-thompson deleted the 1076-remove-flush branch August 29, 2022 17:11
@agarwal-navin agarwal-navin mentioned this pull request Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre4i andre4i andre4i approved these changes

@agarwal-navin agarwal-navin Awaiting requested review from agarwal-navin

Assignees
No one assigned
Labels
area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: next PRs targeted against next branch breaking change This PR or issue would introduce a breaking change msftbot: merge-next public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kian-thompson @msfluid-bot @andre4i