Nit: Fix 'Changeset' capitalization, wrong-cased filenames, Canada type decl #11531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
DLehenbauer
commented
Aug 12, 2022
api-report/tree.api.md
Outdated
| export interface ChangeRebaser<TChange, TFinalChange, TChangeSet> { | ||
| compose(...changes: TChangeSet[]): TChangeSet; | ||
| export interface ChangeRebaser<TChange, TFinalChange, TChangeset> { | ||
| compose(...changes: TChangeset[]): TChangeset; |
There was a problem hiding this comment.
@yann-achard-MS - The capitalization of 'Changeset' came up in another PR, so I did a quick sweep of /tree/.
The prevailing convention is a lower-case 's' (changeset is one word, like hashtable.)
DLehenbauer
commented
Aug 12, 2022
| }; | ||
| }]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Following @seanimam's example of correctly typing the tree return from 'generateCanada()'.
yann-achard-MS
approved these changes
Aug 12, 2022
|
Thanks, @yann-achard-MS! |
|
This commit is queued for merging with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Changeset' is prevailingly spelled with a lowercase 's' (it's a single word, like 'hashtable'):
https://en.wikipedia.org/wiki/Changeset
Fixed a couple of Pascal cased filenames.
Added a type declaration for the output of 'generateCanada()'.