Forbid ".only" in CI builds #11535
Merged
Forbid ".only" in CI builds #11535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: dds
github-actions
bot
added
area: build
github-actions
bot
removed
the
area: dds
anthony-murphy
approved these changes
Aug 16, 2022
|
This commit is queued for merging with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The general idea here is to conditionally include the
--forbid-onlyflag in our mocha config based on an env variable we inject in our pipeline. Most packages don't actually currently depend on themocharc-commonfile in@fluidframework/mocha-test-setup, so this adds.mocharc.jsfiles to all of the client packages that contain tests. I didn't modify existing setups for packages that already have.mocharc.jsfiles (there were only a couple), nor the one for PropertyDDS (it uses mocharc.json with what appears to be slightly tweaked config; I'll let developers of that package decide what they want to do).A sample run where I injected a bad
.onlycan be found here.