Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsprim and json-schema dependency #11541

Merged
merged 2 commits into from Aug 15, 2022

Conversation

jzaffiro
Copy link
Contributor

@jzaffiro jzaffiro commented Aug 12, 2022

Task 1181, updating jsprim to 1.4.2 and json-schema to 0.4.0 to resolve this alert

Packages updated:

  • .\
  • .\azure
  • .\build-tools
  • .\common\lib\common-utils
  • .\server\gitrest
  • .\server\historian
  • .\server\routerlicious
  • .\tools\getkeys

@github-actions github-actions bot added area: server Server related issues (routerlicious) dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Aug 12, 2022
@jzaffiro jzaffiro requested a review from Abe27342 August 12, 2022 23:08
@jzaffiro jzaffiro marked this pull request as ready for review August 12, 2022 23:08
@jzaffiro jzaffiro requested review from a team as code owners August 12, 2022 23:08
@Abe27342
Copy link
Contributor

Abe27342 commented Aug 12, 2022

FYI--we have a bot that links tasks to the ADO backlog if you include them in your description. Typically we do this at the end of the description with the following syntax:

AB#1181

Since the task list isn't public and we want to be inclusive of 3p developers, PR descriptions should be comprehensible without all of the extra context. So here I'd probably just link the CVE (there should be a public link to the prototype-pollution vulnerability you can find starting at the microsoft-internal tooling) and mention it resolves that.

Copy link
Contributor

@Abe27342 Abe27342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Doing a repo-wide search for "json-schema" (ctrl+shift+f in vscode), I still see some other package-locks that reference the vulnerable version. You can update them in this PR or a separate one, either way is fine (though may want to scope the title of the PR to reflect which packages are being updated if you want to do multiple):

image

@Abe27342 Abe27342 changed the title update jsprim and json-schema dependency Update jsprim and json-schema dependency Aug 12, 2022
@Abe27342
Copy link
Contributor

description link is still internal--dev.azure.com links to internal repo won't be accessible. You can find the public page at the bottom of the page you linked by clicking "see advisory for vulnerability details"

image

@jzaffiro jzaffiro merged commit 9c041d2 into microsoft:main Aug 15, 2022
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Server related issues (routerlicious) base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants