Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation: Main Next Integrate #11548

Merged

Conversation

github-actions[bot]
Copy link
Contributor

Main-next integrate PR

The aim of this pull request is to sync main and next branch. The expectation from the assignee is as follows:

  • Acknowledge the pull request by adding a comment -- "Actively working on it".
  • Resolve any merge conflicts between this branch and next (and push the resolution to this branch). Merge next into this branch if needed. Do NOT rebase or squash this branch: its history must be preserved.
  • Ensure CI is passing for this PR, fixing any issues. Please don't look into resolving Real service e2e test and Stress test failures as they are non-required CI failures.

For more information about how to resolve merge conflicts and CI failures, visit this wiki page.

curtisman and others added 3 commits August 12, 2022 15:26
…11527)

We have been only testing against node 14 for a while now. Whether our code still works with node 12, we should just make node 14 the min requirement consistently across the repo.
* Remove logging for pending summaries.
@NicholasCouri
Copy link
Contributor

Actively working on it

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: runtime Runtime related issues area: server Server related issues (routerlicious) area: website public api change Changes to a public API base: next PRs targeted against next branch labels Aug 15, 2022
@NicholasCouri
Copy link
Contributor

@scarlettjlee I had to manually resolve a conflict on packages\dds\merge-tree\src\client.ts - it seems fine to me now but wanted you to confirm just in case.

@scarlettjlee
Copy link
Contributor

The changes in client.ts aren't right. I'll fix it...

@github-actions
Copy link
Contributor Author

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> fluidframework-docs@0.25.0 linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> npm run linkcheck:fast -- --external


> fluidframework-docs@0.25.0 linkcheck:fast /home/runner/work/FluidFramework/FluidFramework/docs
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt "--external"

Crawling...

http://localhost:1313/css/style.min.f22f6c22fcc37a0d857a17c9c1202a67c28deef90cc26a52b7539b903f623331.css
- (1:3811) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.svg (HTTP 503)

http://localhost:1313/docs/apis/core-interfaces/ifluidcodedetailscomparer
- (832:360) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (836:168) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)
- (844:25) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (873:25) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)

http://localhost:1313/docs/apis/core-interfaces/ifluidcodedetailscomparer/
- (832:360) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (836:168) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)
- (844:25) 'Array.sort' => https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#Description (HTTP 200 but missing anchor)
- (873:25) 'https://..' => https://github.com/npm/node-semver#usage (HTTP 200 but missing anchor)


Summary of most serious issues:

http://localhost:1313/css/style.min.f22f6c22fcc37a0d857a17c9c1202a67c28deef90cc26a52b7539b903f623331.css
- (1:3811) url(...) => https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/bold/latest.svg (HTTP 503)


Stats:
  117505 links
    1300 destination URLs
       1 URLs ignored
       8 warnings
       1 errors


@NicholasCouri NicholasCouri self-requested a review August 15, 2022 18:51
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +15.8 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 389.97 KB 391.7 KB +1.74 KB
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 191.96 KB 197.51 KB +5.55 KB
loader.js 151.12 KB 151.06 KB -57 Bytes
map.js 42.63 KB 47.38 KB +4.75 KB
matrix.js 129.27 KB 132.04 KB +2.77 KB
odspDriver.js 150.23 KB 150.11 KB -127 Bytes
odspPrefetchSnapshot.js 38.39 KB 38.35 KB -41 Bytes
sharedString.js 149.91 KB 151.13 KB +1.22 KB
Total Size 1.25 MB 1.26 MB +15.8 KB

Baseline commit: cbba1c2

Generated by 🚫 dangerJS against c023245

@sonalivdeshpande sonalivdeshpande merged commit 801c362 into next Aug 16, 2022
@sonalivdeshpande sonalivdeshpande deleted the main-next-cbba1c2731489f1829cd0155bbd7458ecf124be5 branch August 16, 2022 20:51
@sonalivdeshpande
Copy link
Contributor

thanks @NicholasCouri @scarlettjlee!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds Issues related to distributed data structures area: runtime Runtime related issues area: server Server related issues (routerlicious) area: website base: next PRs targeted against next branch community-contribution do-not-squash-merge main-next-integrate public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants