New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FluidContainer now emitting errors when disposed #11554
Merged
ssimic2
merged 4 commits into
microsoft:next
from
ssimic2:fluid-container-eventing-errors
Aug 18, 2022
Merged
FluidContainer now emitting errors when disposed #11554
ssimic2
merged 4 commits into
microsoft:next
from
ssimic2:fluid-container-eventing-errors
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssimic2
commented
Aug 17, 2022
ChumpChief
reviewed
Aug 17, 2022
ChumpChief
approved these changes
Aug 17, 2022
⯅ @fluid-example/bundle-size-tests: +15.8 KB
Baseline commit: a320268 |
ssimic2
pushed a commit
to ssimic2/FluidFramework
that referenced
this pull request
Oct 4, 2022
ssimic2
pushed a commit
that referenced
this pull request
Oct 13, 2022
Bringing #11554 change to main.
ssimic2
pushed a commit
to ssimic2/FluidFramework
that referenced
this pull request
Oct 13, 2022
ssimic2
pushed a commit
to ssimic2/FluidFramework
that referenced
this pull request
Oct 13, 2022
Bringing microsoft#11554 change to main.
ssimic2
pushed a commit
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
base: next
PRs targeted against next branch
breaking change
This PR or issue would introduce a breaking change
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are now surfacing error field on FluidContainer “disposed” event, so the application can appropriately handle various error types, instead of purely relying on telemetry to root-cause issues. For example, application may want to distinguish more clearly between data corruption vs usage errors. We are not introducing any new concepts on FluidContainer, so we can stay in line with general idea of offering “subset” functionality of underlining container.
Minor: Corrected interface event naming to align with actual event being emitted:
dispose->disposed.To address need in AB#943
Does this introduce a breaking change?
Yes - Minor event naming correction on IFluidContainerEvents.