Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluidContainer now emitting errors when disposed #11554

Merged
merged 4 commits into from Aug 18, 2022

Conversation

ssimic2
Copy link

@ssimic2 ssimic2 commented Aug 16, 2022

Description

We are now surfacing error field on FluidContainer “disposed” event, so the application can appropriately handle various error types, instead of purely relying on telemetry to root-cause issues. For example, application may want to distinguish more clearly between data corruption vs usage errors. We are not introducing any new concepts on FluidContainer, so we can stay in line with general idea of offering “subset” functionality of underlining container.

Minor: Corrected interface event naming to align with actual event being emitted: dispose -> disposed.

To address need in AB#943

Does this introduce a breaking change?

Yes - Minor event naming correction on IFluidContainerEvents.

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct breaking change This PR or issue would introduce a breaking change public api change Changes to a public API base: next PRs targeted against next branch labels Aug 16, 2022
@ssimic2 ssimic2 marked this pull request as ready for review August 17, 2022 00:30
@ssimic2 ssimic2 requested review from msfluid-bot and a team as code owners August 17, 2022 00:30
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Aug 17, 2022

@fluid-example/bundle-size-tests: +15.8 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 392.28 KB 394.02 KB +1.74 KB
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 191.92 KB 197.48 KB +5.55 KB
loader.js 151.12 KB 151.06 KB -57 Bytes
map.js 42.63 KB 47.38 KB +4.75 KB
matrix.js 131.63 KB 134.39 KB +2.77 KB
odspDriver.js 150.23 KB 150.11 KB -127 Bytes
odspPrefetchSnapshot.js 38.39 KB 38.35 KB -41 Bytes
sharedString.js 152.26 KB 153.48 KB +1.21 KB
Total Size 1.25 MB 1.27 MB +15.8 KB

Baseline commit: a320268

Generated by 🚫 dangerJS against d2b1597

@ssimic2 ssimic2 merged commit a3ee279 into microsoft:next Aug 18, 2022
ssimic2 pushed a commit to ssimic2/FluidFramework that referenced this pull request Oct 4, 2022
ssimic2 pushed a commit that referenced this pull request Oct 13, 2022
ssimic2 pushed a commit to ssimic2/FluidFramework that referenced this pull request Oct 13, 2022
ssimic2 pushed a commit to ssimic2/FluidFramework that referenced this pull request Oct 13, 2022
ssimic2 pushed a commit that referenced this pull request Oct 13, 2022
Bringing #12256 and
#11554 to LTS

Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: next PRs targeted against next branch breaking change This PR or issue would introduce a breaking change public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants