Automation: Main Next Integrate #11562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…n tests (#11526) Fixes real service e2e tests targeting tinylicious error running in Windows due to port exhaustion. This should cover any node-fetch calls in both r11s and odsp drivers. Additionally, closes websocket when asked to in Tinylicious.
* Improve partialLengths documentation and simplify where possible * use iterator * Remove unused import, fixing silent merge conflict * WIP adjustments to partialLengths to track local info * Still WIP changes, made more incremental though * Add a test for corectness of recomputation * remove unnecessary ts flag * WIP improvement * Bugfix for clearing segment on detached localRefs * clean up some no longer accurate TODOs * combine local state to one object to simplify undefined asserts * Simplify query logic and add some documentation on strategy * More misc cleanup * Remove outdated comment * Remove kludges relating to overlapping removed client ids * Move slow-path computation to TestClient * Various cleanup and lint fixes * remove stray comment * fix tests, implement caching for local overlap remove case * update api report * PR feedback Co-authored-by: Abram Sanderson <absander@microsoft.com>
…ode details concept (#11529)
github-actions
bot
requested review from
msfluid-bot and
a team
as code owners
|
Working on it |
…2926d68a913d1bbc675df65ea19926a
github-actions
bot
added
base: next
|
@Abe27342 @anthony-murphy FYI as the owners of the conflicting changes. |
|
Rerunning, failures look unrelated. @sonalivdeshpande @tylerbutler I suspect this will be good to merge once it finishes. |
⯅ @fluid-example/bundle-size-tests: +15.8 KB
Baseline commit: 26919c2 |
|
thank you @ChumpChief!! |
sonalivdeshpande
approved these changes
Aug 17, 2022
sonalivdeshpande
deleted the
main-next-26919c2622926d68a913d1bbc675df65ea19926a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main-next integrate PR
The aim of this pull request is to sync main and next branch. The expectation from the assignee is as follows:
For more information about how to resolve merge conflicts and CI failures, visit this wiki page.