Improve package building and packing for @fluid-experiemental/property-inspector-table #11569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evaliyev PTAL |
github-actions
bot
added
area: dds: propertydds
dependencies
experimental/PropertyDDS/packages/property-inspector-table/tsconfig.json
Outdated
Show resolved
Hide resolved
experimental/PropertyDDS/packages/property-inspector-table/webpack.prod.js
Outdated
Show resolved
Hide resolved
experimental/PropertyDDS/packages/property-inspector-table/webpack.config.js
Show resolved
Hide resolved
experimental/PropertyDDS/packages/property-inspector-table/package.json
Outdated
Show resolved
Hide resolved
nedalhy
force-pushed
the
inspector-table/improve_compiling_config
branch
from
c46ddb5
to
2396284
Compare
github-actions
bot
removed
the
dependencies
|
@CraigMacomber @DLehenbaue can we merge this PR ? |
…onfig.json Co-authored-by: Craig Macomber (Microsoft) <42876482+CraigMacomber@users.noreply.github.com>
CraigMacomber
approved these changes
Aug 26, 2022
|
This commit is queued for merging with the |
tyler-cai-microsoft
pushed a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Aug 26, 2022
…y-inspector-table (microsoft#11569)
WayneFerrao
pushed a commit
to WayneFerrao/FluidFramework
that referenced
this pull request
Aug 31, 2022
…y-inspector-table (microsoft#11569)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note - for now webpack is used only for running the storybook and bundling SVGs due to the way its consumed in the library itself - this may change in the future, however, it will require further investigation.
@CraigMacomber FYI