Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Azure CLI and Github CLI from devcontainer definition. #11587

Merged
merged 1 commit into from Aug 22, 2022

Conversation

alexvy86
Copy link
Contributor

Description

Comment Azure CLI and Github CLI in the devcontainer.json file. After discussion within the team, having them be part of the default setup used for Github Codespaces instances is not ideal for security reasons.

Reviewer Guidance

Ping @alexvy86 or @curtisman for details on the internal discussion.

@alexvy86 alexvy86 requested a review from a team as a code owner August 18, 2022 16:20
@github-actions github-actions bot added the base: main PRs targeted against main branch label Aug 18, 2022
@alexvy86 alexvy86 merged commit e06cd89 into microsoft:main Aug 22, 2022
@alexvy86 alexvy86 deleted the revert-tools-in-devcontainer branch August 22, 2022 22:21
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants