Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quorum polish and adding stopping state to migrationTool #11592

Merged
merged 11 commits into from Aug 19, 2022

Conversation

ChumpChief
Copy link
Contributor

@ChumpChief ChumpChief commented Aug 18, 2022

This change does a few cleanup items, mostly TODO items in the Quorum package:

  • Removes has() from IQuorum. This was unreliable given that setting undefined would get cleaned up in summary -- clients would forget the key over time.
  • Uses a TS generic for the quorum contents, similar to our other DDSs like map/cell
  • Adds isPending() to enable distinguishing "nothing pending" from "pending delete/set(undefined)"
  • Moves to using the more-accurate fluid-experimental scope rather than fluid-internal. Since we're still using the private: true flag it will continue to not publish.

It additionally adds a "stopping" state to the migration demo, mapping to the point where the proposal goes pending. This is the point where clients should stop writing new data into the app (as it will not be guaranteed to make it into the migration). This is how it always should have been, just an oversight on my part.

@ChumpChief ChumpChief requested review from a team as code owners August 18, 2022 19:00
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: examples Changes that focus on our examples public api change Changes to a public API labels Aug 18, 2022
@github-actions github-actions bot added the base: main PRs targeted against main branch label Aug 18, 2022
packages/dds/quorum/src/interfaces.ts Outdated Show resolved Hide resolved
packages/dds/quorum/src/quorum.ts Outdated Show resolved Hide resolved
@ChumpChief ChumpChief merged commit 680117a into microsoft:main Aug 19, 2022
@ChumpChief ChumpChief deleted the QuorumCleanup branch August 19, 2022 17:28
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds Issues related to distributed data structures area: examples Changes that focus on our examples base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants