Quorum polish and adding stopping state to migrationTool #11592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does a few cleanup items, mostly TODO items in the Quorum package:
IQuorum. This was unreliable given that settingundefinedwould get cleaned up in summary -- clients would forget the key over time.isPending()to enable distinguishing "nothing pending" from "pending delete/set(undefined)"private: trueflag it will continue to not publish.It additionally adds a "stopping" state to the migration demo, mapping to the point where the proposal goes pending. This is the point where clients should stop writing new data into the app (as it will not be guaranteed to make it into the migration). This is how it always should have been, just an oversight on my part.