Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tinylicious dependency and fix AB#1454 #11597

Merged
merged 2 commits into from Aug 19, 2022
Merged

Update tinylicious dependency and fix AB#1454 #11597

merged 2 commits into from Aug 19, 2022

Conversation

curtisman
Copy link
Member

@curtisman curtisman commented Aug 19, 2022 •
edited

The new version includes in PR #11595 to temporary disable generateServiceSummary, and fix the summaryNack issue in our e2e test AB#1454

Reenable patching http request to keep connection alive.
Reenable the disabled tests due to the summaryNack issue.

@curtisman curtisman requested review from msfluid-bot and a team as code owners August 19, 2022 01:52
@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Aug 19, 2022
@curtisman curtisman requested a review from a team as a code owner August 19, 2022 01:59
@curtisman curtisman merged commit 71a2a14 into microsoft:main Aug 19, 2022
@curtisman curtisman deleted the fixb branch August 19, 2022 12:12
@github-actions
Copy link
Contributor

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

This was referenced Oct 26, 2022
Open
Open
@MarcelRaschke MarcelRaschke mentioned this pull request Nov 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler approved these changes

@NicholasCouri NicholasCouri NicholasCouri approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

@scarlettjlee scarlettjlee Awaiting requested review from scarlettjlee

Assignees
No one assigned
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@curtisman @tylerbutler @NicholasCouri