Remove references to deleted file in YAML pipelines #11607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
curtisman
reviewed
Aug 19, 2022
| @@ -22,7 +22,6 @@ const pkgName = pkg.name; | |||
|
|
|||
| // For test builds, the package version starts with 0.0.0. Code need to know the original version. | |||
| // CI build create one with original version prefix is emitted into the environment for code logic to be used here. | |||
| // See tools/pipelines/scripts/build-version.js | |||
There was a problem hiding this comment.
I believe common/build/build-common/gen_version.js is the new location.
There was a problem hiding this comment.
Right, but that's the file that contains the comment 😄
tylerbutler
approved these changes
Aug 23, 2022
You and @curtisman are probably better equipped to answer that, but to me it doesn't seem like there is. |
|
This commit is queued for merging with the |
This was referenced Nov 4, 2022
This was referenced Nov 4, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bit of cleanup in the ADO pipelines, removing references to a file that was removed earlier this year (its functionality was integrated into our build-common package).
Except for a comment in a
.jsfile, all the changes are in thetriggerssection(s) of pipelines. Since the file does not exist anymore, the pipelines would never trigger because of changes to that path.